Commit 399c496 1 parent 365810a commit 399c496 Copy full SHA for 399c496
File tree 1 file changed +4
-4
lines changed
1 file changed +4
-4
lines changed Original file line number Diff line number Diff line change @@ -395,7 +395,7 @@ fn evaluate_pendings() -> DashResult<()> {
395
395
proposal. id, why) ) ;
396
396
}
397
397
398
- let majority_complete = num_outstanding_reviews < num_complete_reviews;
398
+ let majority_complete = num_outstanding_reviews <= 2 * num_complete_reviews;
399
399
400
400
if num_active_concerns == 0 && majority_complete && num_outstanding_reviews < 3 {
401
401
// TODO only record the fcp as started if we know that we successfully commented
@@ -1197,9 +1197,9 @@ impl<'a> RfcBotComment<'a> {
1197
1197
}
1198
1198
}
1199
1199
1200
- msg. push_str ( "\n Once a majority of reviewers approve (and at most 2 approvals are outstanding), " ) ;
1201
- msg. push_str ( "this will enter its final comment period. " ) ;
1202
- msg. push_str ( "If you spot a major issue that hasn't been raised " ) ;
1200
+ msg. push_str ( "\n Once two thirds of reviewers approve (and at most 2 " ) ;
1201
+ msg. push_str ( "approvals are outstanding), this will enter its final comment " ) ;
1202
+ msg. push_str ( "period. If you spot a major issue that hasn't been raised " ) ;
1203
1203
msg. push_str ( "at any point in this process, please speak up!\n " ) ;
1204
1204
1205
1205
if issue. labels . iter ( ) . any ( |l| l == "T-lang" ) {
You can’t perform that action at this time.
0 commit comments