r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This PR changes Stable MIR

cc @oli-obk, @celinval, @ouz-a

This actually technically conflicts with #137502, which removes global_asm from the mir_keys, and which indirectly fixes the ICE in rust-lang/project-stable-mir#95.

They shouldn't have been there in the first place, but also the fn all_local_items() function is a bit unclear; it should probably be listing global asm items too, and possibly items without bodies like structs. I think it shouldn't be piggybacking off of the mir_keys query at all, but iterating over some other set of local def ids and filtering those out based off of their DefKind.

Could you please wait until #137502 is landed? Then please adjust the fn all_local_items() to be more clear about what kinds of items it's returning 🤔 happy to chat about that if you want to work that design part out.

@rustbot blocked

@compiler-errors let's chat about the kinds of items you think we should return here, and the best way to implement that. This is today one of the main entry points to StableMir.

I'm also considering adding a stable API to get the results from rustc's collector, likely without the cgu part.