Skip to content
This repository was archived by the owner on Feb 5, 2019. It is now read-only.

Commit a62cd42

Browse files
TimNNarielb1
authored andcommitted
[JSBackend] don't use dllexport since it causes problems when building rustc
See: rust-lang/rust#40123 (comment)
1 parent 01e00ed commit a62cd42

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

lib/Target/JSBackend/Relooper.h

+6-1
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,12 @@ struct Debugging {
344344

345345
// C API - useful for binding to other languages
346346

347-
#ifdef _WIN32
347+
// #ifdef _WIN32
348+
// Any item marked as dllexport causes the mingw linker to no longer export
349+
// unmarked symbols, which causes build problems for rustc (since the symbols it
350+
// needs are no longer exported), so make sure all symbols are unmarked.
351+
// See: https://github.com/rust-lang/rust/pull/40123#issuecomment-293798939
352+
#if 0
348353
#ifdef RELOOPERDLL_EXPORTS
349354
#define RELOOPERDLL_API __declspec(dllexport)
350355
#else

0 commit comments

Comments
 (0)