Skip to content

Commit 3695157

Browse files
tgross35tgross35
authored
Merge pull request #4232 from lvllvl/4117-part-4
Classify FIXMEs - 4
2 parents cb4bb18 + ccf7b41 commit 3695157

File tree

11 files changed

+45
-44
lines changed

11 files changed

+45
-44
lines changed

Diff for: ‎src/fuchsia/x86_64.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ cfg_if! {
102102
.field("uc_stack", &self.uc_stack)
103103
.field("uc_mcontext", &self.uc_mcontext)
104104
.field("uc_sigmask", &self.uc_sigmask)
105-
// FIXME: .field("__private", &self.__private)
105+
// FIXME(debug): .field("__private", &self.__private)
106106
.finish()
107107
}
108108
}

Diff for: ‎src/unix/bsd/apple/b32/mod.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ s! {
4545
}
4646

4747
pub struct malloc_zone_t {
48-
__private: [crate::uintptr_t; 18], // FIXME: keeping private for now
48+
__private: [crate::uintptr_t; 18], // FIXME(macos): keeping private for now
4949
}
5050
}
5151

@@ -84,7 +84,7 @@ cfg_if! {
8484
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
8585
f.debug_struct("pthread_attr_t")
8686
.field("__sig", &self.__sig)
87-
// FIXME: .field("__opaque", &self.__opaque)
87+
// FIXME(debug): .field("__opaque", &self.__opaque)
8888
.finish()
8989
}
9090
}

Diff for: ‎src/unix/bsd/apple/b64/aarch64/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ pub type mcontext_t = *mut __darwin_mcontext64;
55

66
s! {
77
pub struct malloc_zone_t {
8-
__private: [crate::uintptr_t; 18], // FIXME: needs arm64 auth pointers support
8+
__private: [crate::uintptr_t; 18], // FIXME(macos): needs arm64 auth pointers support
99
}
1010

1111
pub struct ucontext_t {

Diff for: ‎src/unix/bsd/apple/b64/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ cfg_if! {
7777
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
7878
f.debug_struct("pthread_attr_t")
7979
.field("__sig", &self.__sig)
80-
// FIXME: .field("__opaque", &self.__opaque)
80+
// FIXME(debug): .field("__opaque", &self.__opaque)
8181
.finish()
8282
}
8383
}

Diff for: ‎src/unix/bsd/apple/b64/x86_64/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ s! {
106106
}
107107

108108
pub struct malloc_introspection_t {
109-
_private: [crate::uintptr_t; 16], // FIXME: keeping private for now
109+
_private: [crate::uintptr_t; 16], // FIXME(macos): keeping private for now
110110
}
111111

112112
pub struct malloc_zone_t {

Diff for: ‎src/unix/bsd/apple/mod.rs

+15-15
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@ s! {
361361
}
362362

363363
pub struct sigaction {
364-
// FIXME: this field is actually a union
364+
// FIXME(union): this field is actually a union
365365
pub sa_sigaction: crate::sighandler_t,
366366
pub sa_mask: sigset_t,
367367
pub sa_flags: c_int,
@@ -1304,9 +1304,9 @@ s_no_extra_traits! {
13041304
pub shm_lpid: crate::pid_t,
13051305
pub shm_cpid: crate::pid_t,
13061306
pub shm_nattch: crate::shmatt_t,
1307-
pub shm_atime: crate::time_t, // FIXME: 64-bit wrong align => wrong offset
1308-
pub shm_dtime: crate::time_t, // FIXME: 64-bit wrong align => wrong offset
1309-
pub shm_ctime: crate::time_t, // FIXME: 64-bit wrong align => wrong offset
1307+
pub shm_atime: crate::time_t, // FIXME(macos): 64-bit wrong align => wrong offset
1308+
pub shm_dtime: crate::time_t, // FIXME(macos): 64-bit wrong align => wrong offset
1309+
pub shm_ctime: crate::time_t, // FIXME(macos): 64-bit wrong align => wrong offset
13101310
// FIXME: 64-bit wrong align => wrong offset:
13111311
pub shm_internal: *mut c_void,
13121312
}
@@ -1891,7 +1891,7 @@ cfg_if! {
18911891
.field("pth_curpri", &self.pth_curpri)
18921892
.field("pth_priority", &self.pth_priority)
18931893
.field("pth_maxpriority", &self.pth_maxpriority)
1894-
// FIXME: .field("pth_name", &self.pth_name)
1894+
// FIXME(debug): .field("pth_name", &self.pth_name)
18951895
.finish()
18961896
}
18971897
}
@@ -1957,8 +1957,8 @@ cfg_if! {
19571957
.field("f_fssubtype", &self.f_fssubtype)
19581958
.field("f_fstypename", &self.f_fstypename)
19591959
.field("f_type", &self.f_type)
1960-
// FIXME: .field("f_mntonname", &self.f_mntonname)
1961-
// FIXME: .field("f_mntfromname", &self.f_mntfromname)
1960+
// FIXME(debug): .field("f_mntonname", &self.f_mntonname)
1961+
// FIXME(debug): .field("f_mntfromname", &self.f_mntfromname)
19621962
.field("f_reserved", &self.f_reserved)
19631963
.finish()
19641964
}
@@ -2008,7 +2008,7 @@ cfg_if! {
20082008
.field("d_reclen", &self.d_reclen)
20092009
.field("d_namlen", &self.d_namlen)
20102010
.field("d_type", &self.d_type)
2011-
// FIXME: .field("d_name", &self.d_name)
2011+
// FIXME(debug): .field("d_name", &self.d_name)
20122012
.finish()
20132013
}
20142014
}
@@ -2037,7 +2037,7 @@ cfg_if! {
20372037
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
20382038
f.debug_struct("pthread_rwlock_t")
20392039
.field("__sig", &self.__sig)
2040-
// FIXME: .field("__opaque", &self.__opaque)
2040+
// FIXME(debug): .field("__opaque", &self.__opaque)
20412041
.finish()
20422042
}
20432043
}
@@ -2065,7 +2065,7 @@ cfg_if! {
20652065
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
20662066
f.debug_struct("pthread_mutex_t")
20672067
.field("__sig", &self.__sig)
2068-
// FIXME: .field("__opaque", &self.__opaque)
2068+
// FIXME(debug): .field("__opaque", &self.__opaque)
20692069
.finish()
20702070
}
20712071
}
@@ -2094,7 +2094,7 @@ cfg_if! {
20942094
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
20952095
f.debug_struct("pthread_cond_t")
20962096
.field("__sig", &self.__sig)
2097-
// FIXME: .field("__opaque", &self.__opaque)
2097+
// FIXME(debug): .field("__opaque", &self.__opaque)
20982098
.finish()
20992099
}
21002100
}
@@ -2133,7 +2133,7 @@ cfg_if! {
21332133
.field("ss_family", &self.ss_family)
21342134
.field("__ss_pad1", &self.__ss_pad1)
21352135
.field("__ss_align", &self.__ss_align)
2136-
// FIXME: .field("__ss_pad2", &self.__ss_pad2)
2136+
// FIXME(debug): .field("__ss_pad2", &self.__ss_pad2)
21372137
.finish()
21382138
}
21392139
}
@@ -2173,13 +2173,13 @@ cfg_if! {
21732173
impl fmt::Debug for utmpx {
21742174
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
21752175
f.debug_struct("utmpx")
2176-
// FIXME: .field("ut_user", &self.ut_user)
2176+
// FIXME(debug): .field("ut_user", &self.ut_user)
21772177
.field("ut_id", &self.ut_id)
21782178
.field("ut_line", &self.ut_line)
21792179
.field("ut_pid", &self.ut_pid)
21802180
.field("ut_type", &self.ut_type)
21812181
.field("ut_tv", &self.ut_tv)
2182-
// FIXME: .field("ut_host", &self.ut_host)
2182+
// FIXME(debug): .field("ut_host", &self.ut_host)
21832183
.field("ut_pad", &self.ut_pad)
21842184
.finish()
21852185
}
@@ -2421,7 +2421,7 @@ cfg_if! {
24212421
.field("pth_curpri", &self.pth_curpri)
24222422
.field("pth_priority", &self.pth_priority)
24232423
.field("pth_maxpriority", &self.pth_maxpriority)
2424-
// FIXME: .field("pth_name", &self.pth_name)
2424+
// FIXME(debug): .field("pth_name", &self.pth_name)
24252425
.finish()
24262426
}
24272427
}

Diff for: ‎src/unix/bsd/freebsdlike/dragonfly/mod.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -560,7 +560,7 @@ cfg_if! {
560560
.field("ut_name", &self.ut_name)
561561
.field("ut_id", &self.ut_id)
562562
.field("ut_line", &self.ut_line)
563-
// FIXME: .field("ut_host", &self.ut_host)
563+
// FIXME(debug): .field("ut_host", &self.ut_host)
564564
.field("ut_unused", &self.ut_unused)
565565
.field("ut_session", &self.ut_session)
566566
.field("ut_type", &self.ut_type)
@@ -639,7 +639,7 @@ cfg_if! {
639639
.field("d_type", &self.d_type)
640640
// Ignore __unused1
641641
// Ignore __unused2
642-
// FIXME: .field("d_name", &self.d_name)
642+
// FIXME(debug): .field("d_name", &self.d_name)
643643
.finish()
644644
}
645645
}
@@ -701,10 +701,10 @@ cfg_if! {
701701
.field("f_flags", &self.f_flags)
702702
.field("f_syncwrites", &self.f_syncwrites)
703703
.field("f_asyncwrites", &self.f_asyncwrites)
704-
// FIXME: .field("f_mntonname", &self.f_mntonname)
704+
// FIXME(debug): .field("f_mntonname", &self.f_mntonname)
705705
.field("f_syncreads", &self.f_syncreads)
706706
.field("f_asyncreads", &self.f_asyncreads)
707-
// FIXME: .field("f_mntfromname", &self.f_mntfromname)
707+
// FIXME(debug): .field("f_mntfromname", &self.f_mntfromname)
708708
.finish()
709709
}
710710
}

Diff for: ‎src/unix/bsd/freebsdlike/freebsd/mod.rs

+7-7
Original file line numberDiff line numberDiff line change
@@ -1660,7 +1660,7 @@ s_no_extra_traits! {
16601660
pub kf_flags: c_int,
16611661
_kf_pad0: c_int,
16621662
pub kf_offset: i64,
1663-
_priv: [u8; 304], // FIXME: this is really a giant union
1663+
_priv: [u8; 304], // FIXME(freebsd): this is really a giant union
16641664
pub kf_status: u16,
16651665
_kf_pad1: u16,
16661666
_kf_ispare0: c_int,
@@ -1711,8 +1711,8 @@ cfg_if! {
17111711
.field("ut_pid", &self.ut_pid)
17121712
.field("ut_user", &self.ut_user)
17131713
.field("ut_line", &self.ut_line)
1714-
// FIXME: .field("ut_host", &self.ut_host)
1715-
// FIXME: .field("__ut_spare", &self.__ut_spare)
1714+
// FIXME(debug): .field("ut_host", &self.ut_host)
1715+
// FIXME(debug): .field("__ut_spare", &self.__ut_spare)
17161716
.finish()
17171717
}
17181718
}
@@ -1799,7 +1799,7 @@ cfg_if! {
17991799
.field("sdl_nlen", &self.sdl_nlen)
18001800
.field("sdl_alen", &self.sdl_alen)
18011801
.field("sdl_slen", &self.sdl_slen)
1802-
// FIXME: .field("sdl_data", &self.sdl_data)
1802+
// FIXME(debug): .field("sdl_data", &self.sdl_data)
18031803
.finish()
18041804
}
18051805
}
@@ -2291,7 +2291,7 @@ cfg_if! {
22912291
f.debug_struct("sctp_gen_error_cause")
22922292
.field("code", &{ self.code })
22932293
.field("length", &{ self.length })
2294-
// FIXME: .field("info", &{self.info})
2294+
// FIXME(debug): .field("info", &{self.info})
22952295
.finish()
22962296
}
22972297
}
@@ -2363,7 +2363,7 @@ cfg_if! {
23632363
f.debug_struct("sctp_error_missing_param")
23642364
.field("cause", &{ self.cause })
23652365
.field("num_missing_params", &{ self.num_missing_params })
2366-
// FIXME: .field("tpe", &{self.tpe})
2366+
// FIXME(debug): .field("tpe", &{self.tpe})
23672367
.finish()
23682368
}
23692369
}
@@ -5664,7 +5664,7 @@ extern "C" {
56645664
pub fn pidfile_close(path: *mut crate::pidfh) -> c_int;
56655665
pub fn pidfile_remove(path: *mut crate::pidfh) -> c_int;
56665666
pub fn pidfile_fileno(path: *const crate::pidfh) -> c_int;
5667-
// FIXME: pidfile_signal in due time (both manpage present and updated image snapshot)
5667+
// FIXME(freebsd): pidfile_signal in due time (both manpage present and updated image snapshot)
56685668
}
56695669

56705670
#[link(name = "procstat")]

Diff for: ‎src/unix/bsd/freebsdlike/freebsd/x86_64/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ cfg_if! {
344344
.field("mc_len", &self.mc_len)
345345
.field("mc_fpformat", &self.mc_fpformat)
346346
.field("mc_ownedfp", &self.mc_ownedfp)
347-
// FIXME: .field("mc_fpstate", &self.mc_fpstate)
347+
// FIXME(debug): .field("mc_fpstate", &self.mc_fpstate)
348348
.field("mc_fsbase", &self.mc_fsbase)
349349
.field("mc_gsbase", &self.mc_gsbase)
350350
.field("mc_xfpustate", &self.mc_xfpustate)

Diff for: ‎src/unix/bsd/freebsdlike/mod.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,7 @@ cfg_if! {
418418
.field("ss_family", &self.ss_family)
419419
.field("__ss_pad1", &self.__ss_pad1)
420420
.field("__ss_align", &self.__ss_align)
421-
// FIXME: .field("__ss_pad2", &self.__ss_pad2)
421+
// FIXME(debug): .field("__ss_pad2", &self.__ss_pad2)
422422
.finish()
423423
}
424424
}

Diff for: ‎src/unix/bsd/netbsdlike/netbsd/mod.rs

+11-10
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ pub type fsfilcnt_t = u64;
1010
pub type idtype_t = c_int;
1111
pub type mqd_t = c_int;
1212
type __pthread_spin_t = __cpu_simple_lock_nv_t;
13-
pub type vm_size_t = crate::uintptr_t; // FIXME: deprecated since long time
13+
pub type vm_size_t = crate::uintptr_t; // FIXME(deprecated): deprecated since long time
1414
pub type lwpid_t = c_uint;
1515
pub type shmatt_t = c_uint;
1616
pub type cpuid_t = c_ulong;
@@ -297,7 +297,8 @@ s! {
297297
pub flags: u32,
298298
pub fflags: u32,
299299
pub data: i64,
300-
pub udata: intptr_t, /* FIXME: NetBSD 10.0 will finally have same layout as other BSD */
300+
// FIXME(netbsd): NetBSD 10.0 will finally have same layout as other BSD
301+
pub udata: intptr_t,
301302
}
302303

303304
pub struct dqblk {
@@ -799,7 +800,7 @@ s_no_extra_traits! {
799800
pub ut_session: u16,
800801
pub ut_type: u16,
801802
pub ut_pid: crate::pid_t,
802-
pub ut_exit: __exit_status, // FIXME: when anonymous struct are supported
803+
pub ut_exit: __exit_status, // FIXME(netbsd): when anonymous struct are supported
803804
pub ut_ss: sockaddr_storage,
804805
pub ut_tv: crate::timeval,
805806
pub ut_pad: [u8; _UTX_PADSIZE],
@@ -945,14 +946,14 @@ cfg_if! {
945946
.field("ut_name", &self.ut_name)
946947
.field("ut_id", &self.ut_id)
947948
.field("ut_line", &self.ut_line)
948-
// FIXME .field("ut_host", &self.ut_host)
949+
// FIXME(debug) .field("ut_host", &self.ut_host)
949950
.field("ut_session", &self.ut_session)
950951
.field("ut_type", &self.ut_type)
951952
.field("ut_pid", &self.ut_pid)
952953
.field("ut_exit", &self.ut_exit)
953954
.field("ut_ss", &self.ut_ss)
954955
.field("ut_tv", &self.ut_tv)
955-
// FIXME .field("ut_pad", &self.ut_pad)
956+
// FIXME(debug) .field("ut_pad", &self.ut_pad)
956957
.finish()
957958
}
958959
}
@@ -993,7 +994,7 @@ cfg_if! {
993994
f.debug_struct("lastlogx")
994995
.field("ll_tv", &self.ll_tv)
995996
.field("ll_line", &self.ll_line)
996-
// FIXME.field("ll_host", &self.ll_host)
997+
// FIXME(debug).field("ll_host", &self.ll_host)
997998
.field("ll_ss", &self.ll_ss)
998999
.finish()
9991000
}
@@ -1159,7 +1160,7 @@ cfg_if! {
11591160
.field("d_reclen", &self.d_reclen)
11601161
.field("d_namlen", &self.d_namlen)
11611162
.field("d_type", &self.d_type)
1162-
// FIXME: .field("d_name", &self.d_name)
1163+
// FIXME(debug): .field("d_name", &self.d_name)
11631164
.finish()
11641165
}
11651166
}
@@ -1235,8 +1236,8 @@ cfg_if! {
12351236
.field("f_owner", &self.f_owner)
12361237
.field("f_spare", &self.f_spare)
12371238
.field("f_fstypename", &self.f_fstypename)
1238-
// FIXME: .field("f_mntonname", &self.f_mntonname)
1239-
// FIXME: .field("f_mntfromname", &self.f_mntfromname)
1239+
// FIXME(debug): .field("f_mntonname", &self.f_mntonname)
1240+
// FIXME(debug): .field("f_mntfromname", &self.f_mntfromname)
12401241
.finish()
12411242
}
12421243
}
@@ -1290,7 +1291,7 @@ cfg_if! {
12901291
.field("ss_family", &self.ss_family)
12911292
.field("__ss_pad1", &self.__ss_pad1)
12921293
.field("__ss_pad2", &self.__ss_pad2)
1293-
// FIXME: .field("__ss_pad3", &self.__ss_pad3)
1294+
// FIXME(debug): .field("__ss_pad3", &self.__ss_pad3)
12941295
.finish()
12951296
}
12961297
}

0 commit comments

Comments
 (0)