Skip to content

Commit 1db895d

Browse files
Update github3 to 3.2 release
1 parent a0acbf5 commit 1db895d

File tree

5 files changed

+6
-13
lines changed

5 files changed

+6
-13
lines changed

.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
pull_request: {}
99

1010
env:
11-
PYTHON_VERSION: 3.8
11+
PYTHON_VERSION: "3.10"
1212

1313
jobs:
1414
cicd:

Dockerfile

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
FROM ubuntu:focal
2-
# We need an older Ubuntu as github3 depends on < Python 3.10 to avoid errors
1+
FROM ubuntu:jammy
32

43
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
54
python3-pip \

homu/main.py

+2-6
Original file line numberDiff line numberDiff line change
@@ -1627,9 +1627,7 @@ def synchronize(repo_label, repo_cfg, logger, gh, states, repos, db, mergeable_q
16271627
db,
16281628
states,
16291629
sha=comment.original_commit_id,
1630-
command_src=comment.to_json()['html_url'],
1631-
# FIXME switch to `comment.html_url`
1632-
# after updating github3 to 1.3.0+
1630+
command_src=comment.html_url
16331631
)
16341632

16351633
for comment in pull.iter_issue_comments():
@@ -1643,9 +1641,7 @@ def synchronize(repo_label, repo_cfg, logger, gh, states, repos, db, mergeable_q
16431641
my_username,
16441642
db,
16451643
states,
1646-
command_src=comment.to_json()['html_url'],
1647-
# FIXME switch to `comment.html_url`
1648-
# after updating github3 to 1.3.0+
1644+
command_src=comment.html_url
16491645
)
16501646

16511647
saved_state = saved_states.get(pull.number)

homu/server.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -478,9 +478,7 @@ def github():
478478
g.my_username,
479479
g.db,
480480
g.states,
481-
command_src=c.to_json()['html_url'],
482-
# FIXME switch to `c.html_url`
483-
# after updating github3 to 1.3.0+
481+
command_src=c.html_url
484482
) or found
485483

486484
status = ''

setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
packages=['homu'],
1313
install_requires=[
14-
'github3.py==0.9.6',
14+
'github3.py==3.2.0',
1515
'toml',
1616
'Jinja2',
1717
'requests',

0 commit comments

Comments
 (0)