Use set() over take() to ensure sink is dropped

ebkalderon · ebkalderon · commit 28ab681e2e32 · 2019-02-27T18:24:23.000+08:00
diff --git a/futures-util/src/stream/forward.rs b/futures-util/src/stream/forward.rs
@@ -85,7 +85,7 @@ where
                 Poll::Ready(None) => {
                     try_ready!(self.as_mut().sink().as_pin_mut().expect(INVALID_POLL)
                                    .poll_close(waker));
-                    let _ = self.as_mut().sink().as_pin_mut().take().unwrap();
+                    self.as_mut().sink().set(None);
                     return Poll::Ready(Ok(()))
                 }
                 Poll::Pending => {

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ where`
`85`	`85`	`Poll::Ready(None) => {`
`86`	`86`	`try_ready!(self.as_mut().sink().as_pin_mut().expect(INVALID_POLL)`
`87`	`87`	`.poll_close(waker));`
`88`		`- let _ = self.as_mut().sink().as_pin_mut().take().unwrap();`
	`88`	`+ self.as_mut().sink().set(None);`
`89`	`89`	`return Poll::Ready(Ok(()))`
`90`	`90`	`}`
`91`	`91`	`Poll::Pending => {`