Skip to content

Commit fc21f64

Browse files
Remove blacklisting for URIs starting with /-/ and move /menus/ routes to /-/menus/
1 parent 75541b6 commit fc21f64

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

src/web/crate_details.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -1247,7 +1247,7 @@ mod tests {
12471247

12481248
let response = env
12491249
.frontend()
1250-
.get("/menus/platforms/dummy/0.4.0/x86_64-pc-windows-msvc")
1250+
.get("/-/menus/platforms/dummy/0.4.0/x86_64-pc-windows-msvc")
12511251
.send()?;
12521252
assert!(response.status().is_success());
12531253

src/web/routes.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ use axum_extra::routing::RouterExt;
1414
use std::convert::Infallible;
1515
use tracing::{debug, instrument};
1616

17-
const INTERNAL_PREFIXES: &[&str] = &["-", "about", "crate", "releases", "sitemap.xml"];
17+
const INTERNAL_PREFIXES: &[&str] = &["about", "crate", "releases", "sitemap.xml"];
1818

1919
#[instrument(skip_all)]
2020
pub(crate) fn get_static<H, T, S, B>(handler: H) -> MethodRouter<S, B, Infallible>
@@ -237,19 +237,19 @@ pub(super) fn build_axum_routes() -> AxumRouter {
237237
get_internal(super::source::source_browser_handler),
238238
)
239239
.route(
240-
"/menus/platforms/:name/:version/:target",
240+
"/-/menus/platforms/:name/:version/:target",
241241
get_internal(super::crate_details::get_all_platforms),
242242
)
243243
.route(
244-
"/menus/platforms/:name/:version/:target/",
244+
"/-/menus/platforms/:name/:version/:target/",
245245
get_internal(super::crate_details::get_all_platforms),
246246
)
247247
.route(
248-
"/menus/platforms/:name/:version/:target/*path",
248+
"/-/menus/platforms/:name/:version/:target/*path",
249249
get_internal(super::crate_details::get_all_platforms),
250250
)
251251
.route(
252-
"/menus/releases/:name",
252+
"/-/menus/releases/:name",
253253
get_internal(super::crate_details::get_all_releases),
254254
)
255255
.route(

src/web/rustdoc.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -2261,7 +2261,7 @@ mod test {
22612261
// test rustdoc pages stay on the documentation
22622262
let page = kuchikiki::parse_html().one(
22632263
env.frontend()
2264-
.get("/menus/releases/hexponent")
2264+
.get("/-/menus/releases/hexponent")
22652265
.send()?
22662266
.text()?,
22672267
);

static/menu.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ function loadAjaxMenu(menu, id, msg, path, extra) {
3333
document.getElementById(id).innerHTML = `Failed to load ${msg}`;
3434
}
3535
};
36-
xhttp.open("GET", `/menus/${path}/${crateName}${extra}`, true);
36+
xhttp.open("GET", `/-/menus/${path}/${crateName}${extra}`, true);
3737
xhttp.send();
3838
};
3939

0 commit comments

Comments
 (0)