Auto merge of #1880 - rust-lang:jquery-integration, r=carols10cents

Replace jQuery logic with native DOM

Author: bors

app/components/api-token-row.js

@@ -7,8 +7,9 @@ export default Component.extend({
   serverError: null,
 
   didInsertElement() {
-    if (this.get('api_token.isNew')) {
-      this.$('input').focus();
+    let input = this.element.querySelector('input');
+    if (input.focus) {
+      input.focus();
     }
   },
 

app/components/crate-readme.js

@@ -2,18 +2,12 @@ import Component from '@ember/component';
 
 export default Component.extend({
   rendered: '',
+
   didRender() {
     this._super(...arguments);
-    this.$('pre > code').each(function() {
-      window.Prism.highlightElement(this);
-    });
-    this.scrollToFragment();
-  },
 
-  scrollToFragment() {
-    if (location.hash) {
-      let anchor_id = location.hash.substr(1);
-      document.getElementById(anchor_id).scrollIntoView();
-    }
+    this.element.querySelectorAll('pre > code').forEach(function(node) {
+      window.Prism.highlightElement(node);
+    });
   },
 });

app/components/rl-dropdown.js

@@ -1,7 +1,6 @@
 import Component from '@ember/component';
 import { alias } from '@ember/object/computed';
 import { computed } from '@ember/object';
-import $ from 'jquery';
 
 import RlDropdownContainer from './rl-dropdown-container';
 
@@ -15,26 +14,17 @@ export default Component.extend({
 
   isExpanded: alias('dropdownContainer.dropdownExpanded'),
 
-  closeOnChildClick: false,
-
-  propagateClicks: true,
-
   click(event) {
-    let closeOnChildClick = this.closeOnChildClick;
-    let propagateClicks = this.propagateClicks;
-    let $target = $(event.target);
-    let $c = this.$();
+    let closeOnChildClick = 'a:link';
+    let $target = event.target;
+    let $c = this.element;
 
-    if ($target !== $c) {
-      if ((closeOnChildClick === true || closeOnChildClick === 'true') && $target.closest($c).length) {
-        this.set('isExpanded', false);
-      } else if (closeOnChildClick && $target.closest(closeOnChildClick, $c).length) {
-        this.set('isExpanded', false);
-      }
+    if ($target === $c) {
+      return;
     }
 
-    if (propagateClicks === false || propagateClicks === 'false') {
-      event.stopPropagation();
+    if ($target.closest(closeOnChildClick, $c).length) {
+      this.set('isExpanded', false);
     }
   },
 });

app/templates/application.hbs

@@ -40,7 +40,7 @@
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
 
-      {{#rl-dropdown tagName="ul" id="doc-links" class="dropdown" closeOnChildClick="a:link"}}
+      {{#rl-dropdown tagName="ul" id="doc-links" class="dropdown"}}
         <li><a href='https://doc.rust-lang.org/cargo/getting-started/'>Getting Started</a></li>
         <li><a href='https://doc.rust-lang.org/cargo/guide/'>Guide</a></li>
         <li><a href='https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html'>Specifying Dependencies</a></li>
@@ -66,7 +66,7 @@
           <span class='arrow'></span>
         {{/rl-dropdown-toggle}}
 
-        {{#rl-dropdown tagName="ul" class="dropdown current-user-links" closeOnChildClick="a:link"}}
+        {{#rl-dropdown tagName="ul" class="dropdown current-user-links"}}
           <li>{{#link-to 'dashboard'}}Dashboard{{/link-to}}</li>
           <li>{{#link-to 'me'}}Account Settings{{/link-to}}</li>
           <li>{{#link-to 'me.pending-invites'}}Owner Invites{{/link-to}}</li>
@@ -87,7 +87,7 @@
         Menu
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
-      {{#rl-dropdown tagName='ul' class='dropdown current-user-links' closeOnChildClick='a:link'}}
+      {{#rl-dropdown tagName='ul' class='dropdown current-user-links'}}
         <li>{{#link-to "crates"}}Browse All Crates{{/link-to}}</li>
         {{#if session.currentUser}}
           <li>{{#link-to 'dashboard'}}Dashboard{{/link-to}}</li>

app/templates/categories.hbs

@@ -23,7 +23,7 @@
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
 
-      {{#rl-dropdown tagName="ul" class="dropdown" closeOnChildClick="a:link"}}
+      {{#rl-dropdown tagName="ul" class="dropdown"}}
         <li>
           {{#link-to (query-params sort="alpha")}}
             Alphabetical

app/templates/category/index.hbs

@@ -56,7 +56,7 @@
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
 
-      {{#rl-dropdown tagName="ul" class="dropdown" closeOnChildClick="a:link"}}
+      {{#rl-dropdown tagName="ul" class="dropdown"}}
         <li>
           {{#link-to (query-params sort="alpha")}}
             Alphabetical

app/templates/components/api-token-row.hbs

@@ -6,8 +6,10 @@
           placeholder="New token name"
           disabled=api_token.isSaving
           value=api_token.name
-          autofocus=true
-          enter="saveToken"}}
+          autofocus="autofocus"
+          enter="saveToken"
+          data-test-focused-input=true
+      }}
     {{else}}
       {{ api_token.name }}
     {{/if}}

app/templates/crates.hbs

@@ -44,7 +44,7 @@
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
 
-      {{#rl-dropdown tagName="ul" class="dropdown" closeOnChildClick="a:link"}}
+      {{#rl-dropdown tagName="ul" class="dropdown"}}
         <li>
           {{#link-to (query-params page=1 sort="alpha")}}
             Alphabetical

app/templates/keyword/index.hbs

@@ -24,7 +24,7 @@
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
 
-      {{#rl-dropdown tagName="ul" class="dropdown" closeOnChildClick="a:link"}}
+      {{#rl-dropdown tagName="ul" class="dropdown"}}
         <li>
           {{#link-to (query-params sort="alpha")}}
             Alphabetical

app/templates/keywords.hbs

@@ -23,7 +23,7 @@
         <span class='arrow'></span>
       {{/rl-dropdown-toggle}}
 
-      {{#rl-dropdown tagName="ul" class="dropdown" closeOnChildClick="a:link"}}
+      {{#rl-dropdown tagName="ul" class="dropdown"}}
         <li>
           {{#link-to (query-params sort="alpha")}}
             Alphabetical