-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup typos check in CI (for rust repo) #817
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed. Concerns or objections to the proposal should be discussed on Zulip and formally registered here by adding a comment with the following syntax:
Concerns can be lifted with:
See documentation at https://forge.rust-lang.org cc @rust-lang/compiler |
@rfcbot concern contributor friction |
@rustbot second |
@rfcbot resolve contributor friction |
@rustbot label -final-comment-period +major-change-accepted |
@rfcbot concern contributor friction Reverting accepted status because this concern is not addressed |
Proposal
Add step to rust CI to check code/comments for typos, to keep things clean.
There was previous attempts to add this (links?), but they produced a lot of false positives. PR (rust-lang/rust#134006) adds that check and also contains (https://github.com/rust-lang/rust/blob/16ab024f2546607eb3f3aa3aa96eb3e382c442f5/typos.toml) short'ish exclusion list, so maintaining it should not be painful.
Currently implemented for: compiler, library, bootstrap, librustdoc.
Spellcheck did not break any other jobs on fail, it run separately and and results available in ~ 20 seconds.
Mentors or Reviewers
If you have a reviewer or mentor in mind for this work, mention them
here. You can put your own name here if you are planning to mentor the
work.
Process
The main points of the Major Change Process are as follows:
@rustbot second
.-C flag
, then full team check-off is required.@rfcbot fcp merge
on either the MCP or the PR.You can read more about Major Change Proposals on forge.
Comments
This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.
The text was updated successfully, but these errors were encountered: