Skip to content

Commit 6f214ac

Browse files
committed
Make ignored key in config be an error
Signed-off-by: hi-rustin <[email protected]>
1 parent 85ba14c commit 6f214ac

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

src/cargo/util/toml/mod.rs

+4-5
Original file line numberDiff line numberDiff line change
@@ -1734,12 +1734,11 @@ impl<P: ResolveToPath> DetailedTomlDependency<P> {
17341734

17351735
for &(key, key_name) in &git_only_keys {
17361736
if key.is_some() {
1737-
let msg = format!(
1738-
"key `{}` is ignored for dependency ({}). \
1739-
This will be considered an error in future versions",
1740-
key_name, name_in_toml
1737+
bail!(
1738+
"key `{}` is ignored for dependency ({}).",
1739+
key_name,
1740+
name_in_toml
17411741
);
1742-
cx.warnings.push(msg)
17431742
}
17441743
}
17451744
}

tests/testsuite/bad_config.rs

+7-3
Original file line numberDiff line numberDiff line change
@@ -1183,9 +1183,13 @@ fn ignored_git_revision() {
11831183

11841184
foo.cargo("build -v")
11851185
.with_status(101)
1186-
.with_stderr_contains(
1187-
"[WARNING] key `branch` is ignored for dependency (bar). \
1188-
This will be considered an error in future versions",
1186+
.with_stderr(
1187+
"\
1188+
error: failed to parse manifest at `[..]`
1189+
1190+
Caused by:
1191+
key `branch` is ignored for dependency (bar).
1192+
",
11891193
)
11901194
.run();
11911195
}

0 commit comments

Comments
 (0)