fix(command-vendor): fix the issue

Author: vksir

src/cargo/ops/vendor.rs

@@ -292,13 +292,23 @@ fn sync(
                 let unpacked_src =
                     registry.unpack_package_in(id, staging_dir.path(), &vendor_this)?;
                 if let Err(e) = fs::rename(&unpacked_src, &dst) {
-                    // This fallback is mainly for Windows 10 versions earlier than 1607.
-                    // The destination of `fs::rename` can't be a directory in older versions.
-                    // Can be removed once the minimal supported Windows version gets bumped.
+                    // This fallback is worked for sometimes `fs::rename` failed in a specific situation, such as:
+                    // - In Windows 10 versions earlier than 1607, the destination of `fs::rename` can't be a directory in older versions.
+                    // - `from` and `to` are on separate filesystems.
+                    // - AntiVirus or our system indexer are doing stuf simutaneously.
+                    // - Any other reasons documented in std::fs::rename.
                     tracing::warn!("failed to `mv {unpacked_src:?} {dst:?}`: {e}");
                     let paths: Vec<_> = walkdir(&unpacked_src).map(|e| e.into_path()).collect();
-                    cp_sources(pkg, src, &paths, &dst, &mut file_cksums, &mut tmp_buf, gctx)
-                        .with_context(|| format!("failed to copy vendored sources for {id}"))?;
+                    cp_sources(
+                        pkg,
+                        &unpacked_src,
+                        &paths,
+                        &dst,
+                        &mut file_cksums,
+                        &mut tmp_buf,
+                        gctx,
+                    )
+                    .with_context(|| format!("failed to copy vendored sources for {id}"))?;
                 } else {
                     compute_file_cksums(&dst)?;
                 }

tests/testsuite/vendor.rs

@@ -2118,11 +2118,18 @@ fn vendor_rename_fallback() {
 ...
 [..]failed to `mv "[..]vendor[..].vendor-staging[..]log-0.3.5" "[..]vendor[..]log"`: [..]
 ...
-[..]StripPrefixError[..]
+Caused by:
+  failed to copy vendored sources for log v0.3.5
+
+Caused by:
+  failed to create directory `[..]log`
+
+Caused by:
+  File exists[..]
 ...
 "#]])
         .run();
 
-    // The cp_sources fallback didn't work because of the StripPrefixError
+    // The cp_sources fallback didn't work because the vendor/log file still exists, not becuase of StripPrefixError
     assert!(!p.root().join("vendor/log/Cargo.toml").exists());
 }