Fix removal highlighting for multiple indented lines#407
Closed
0x2a-42 wants to merge 2 commits intorust-lang:mainfrom
Closed
Fix removal highlighting for multiple indented lines#4070x2a-42 wants to merge 2 commits intorust-lang:mainfrom
0x2a-42 wants to merge 2 commits intorust-lang:mainfrom
Conversation
Member
|
Sorry for the delay in reviewing this PR; my day job has been very busy lately, leaving me little time for open source work. I want to thank you for taking the time to investigate the issue! It was a big help while I was digging into the issue and your solution! While I was digging into it, I realized that switching to removing all trailing whitespace only addressed a symptom of the underlying issue, which led me to dig deeper and eventually open #413. I am going to close this PR in favor of that one. Again, thank you for all the time and effort you put into #405 and this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #405.
I think this change should cause partially removed lines, where only whitespace characters remain, to be treated like completely removed lines.
All tests pass except for
multiple_highlight_duplicated, which does however not show any visual changes. The only difference is that previously some whitespace characters where not highlighted in red.