Skip to content

Commit e45d7ef

Browse files
committed
Disable linkcheck in PRs until bugs are fixed
See Michael-F-Bryan/mdbook-linkcheck#77 and Michael-F-Bryan/mdbook-linkcheck#86. These bugs are causing linkcheck to erroneously fail because we run it using `-f`, to avoid too many requests. For now, disable linkcheck in PR CI, though leave it enabled in the cron job, where the bug should not occur.
1 parent 297ebf2 commit e45d7ef

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/doc/rustc-dev-guide/ci/linkcheck.sh

+6
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ if [ "$GITHUB_EVENT_NAME" = "schedule" ] ; then # running in scheduled job
1414

1515
echo "Doing full link check."
1616
elif [ "$GITHUB_EVENT_NAME" = "pull_request" ] ; then # running in PR CI build
17+
echo "*** WARNING: linkcheck temporarily disabled due to bugs ***"
18+
exit 0
19+
1720
if [ -z "$BASE_SHA" ]; then
1821
echo "error: unexpected state: BASE_SHA must be non-empty in CI"
1922
exit 1
@@ -25,6 +28,9 @@ elif [ "$GITHUB_EVENT_NAME" = "pull_request" ] ; then # running in PR CI build
2528

2629
echo "Checking files changed since $BASE_SHA: $CHANGED_FILES"
2730
else # running locally
31+
echo "*** WARNING: linkcheck temporarily disabled due to bugs ***"
32+
exit 0
33+
2834
COMMIT_RANGE=master...
2935
CHANGED_FILES=$(git diff --name-only $COMMIT_RANGE | sed 's#^src/##' | tr '\n' ' ')
3036
FLAGS="-f $CHANGED_FILES"

0 commit comments

Comments
 (0)