Skip to content

Commit b79f816

Browse files
authored
Rollup merge of rust-lang#138735 - jieyouxu:drop-llvm-alias, r=nikic
Remove `llvm` and `llvms` triagebot ping aliases for `icebreakers-llvm` ping group Because it's way too easy to confuse LLVM Icebreakers ping group versus trying to ping WG-llvm. And AFAIK, icebreakers-llvm isn't really used in a good while. I also fixed the rustc-dev-guide docs about ``@rustbot` ping llvm` (and changed that to the raw ping group name ``@rustbot` icebreakers-llvm`) because it's very confusing. Previously discussed in [#t-compiler/wg-llvm > Ping group renaming](https://rust-lang.zulipchat.com/#narrow/channel/187780-t-compiler.2Fwg-llvm/topic/Ping.20group.20renaming/with/453005029). FYI `@rust-lang/wg-llvm` FYI `@RalfJung` (since you asked in rust-lang#138120 (comment)) r? `@nikic` (or wg-llvm)
2 parents 55fa3f7 + 496c251 commit b79f816

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

src/doc/rustc-dev-guide/src/notification-groups/about.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Here's the list of the notification groups:
2323
- [ARM](./arm.md)
2424
- [Cleanup Crew](./cleanup-crew.md)
2525
- [Emscripten](./emscripten.md)
26-
- [LLVM](./llvm.md)
26+
- [LLVM Icebreakers](./llvm.md)
2727
- [RISC-V](./risc-v.md)
2828
- [WASI](./wasi.md)
2929
- [WebAssembly](./wasm.md)
@@ -83,7 +83,7 @@ group. For example:
8383
@rustbot ping arm
8484
@rustbot ping cleanup-crew
8585
@rustbot ping emscripten
86-
@rustbot ping llvm
86+
@rustbot ping icebreakers-llvm
8787
@rustbot ping risc-v
8888
@rustbot ping wasi
8989
@rustbot ping wasm

src/doc/rustc-dev-guide/src/notification-groups/llvm.md

+8-5
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
1-
# LLVM Notification group
1+
# LLVM Icebreakers Notification group
22

33
**Github Label:** [A-LLVM] <br>
4-
**Ping command:** `@rustbot ping llvm`
4+
**Ping command:** `@rustbot ping icebreakers-llvm`
55

66
[A-LLVM]: https://github.com/rust-lang/rust/labels/A-LLVM
77

8-
The "LLVM Notification Group" are focused on bugs that center around LLVM.
9-
These bugs often arise because of LLVM optimizations gone awry, or as
10-
the result of an LLVM upgrade. The goal here is:
8+
*Note*: this notification group is *not* the same as the LLVM working group
9+
(WG-llvm).
10+
11+
The "LLVM Icebreakers Notification Group" are focused on bugs that center around
12+
LLVM. These bugs often arise because of LLVM optimizations gone awry, or as the
13+
result of an LLVM upgrade. The goal here is:
1114

1215
- to determine whether the bug is a result of us generating invalid LLVM IR,
1316
or LLVM misoptimizing;

triagebot.toml

-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ add_labels = ["S-waiting-on-review"]
4747
[glacier]
4848

4949
[ping.icebreakers-llvm]
50-
alias = ["llvm", "llvms"]
5150
message = """\
5251
Hey LLVM ICE-breakers! This bug has been identified as a good
5352
"LLVM ICE-breaking candidate". In case it's useful, here are some

0 commit comments

Comments
 (0)