Skip to content

Commit 35fc835

Browse files
committed
Auto merge of rust-lang#76423 - Mark-Simulacrum:stable-bootstrap, r=jyn514
Make bootstrap build on beta This is generally a good idea, and will help with being able to build bootstrap without Python over time as it means we can "just" build with cargo +beta build rather than needing the user to set environment variables. This is a minor step, but a necessary one on that road. r? `@jyn514`
2 parents e82584a + 2656d34 commit 35fc835

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

src/bootstrap/bootstrap.py

-1
Original file line numberDiff line numberDiff line change
@@ -714,7 +714,6 @@ def build_bootstrap(self):
714714
# See also: <https://github.com/rust-lang/rust/issues/70208>.
715715
if "CARGO_BUILD_TARGET" in env:
716716
del env["CARGO_BUILD_TARGET"]
717-
env["RUSTC_BOOTSTRAP"] = '1'
718717
env["CARGO_TARGET_DIR"] = build_dir
719718
env["RUSTC"] = self.rustc()
720719
env["LD_LIBRARY_PATH"] = os.path.join(self.bin_root(), "lib") + \

src/bootstrap/lib.rs

-2
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,6 @@
103103
//! More documentation can be found in each respective module below, and you can
104104
//! also check out the `src/bootstrap/README.md` file for more information.
105105
106-
#![feature(drain_filter)]
107-
108106
use std::cell::{Cell, RefCell};
109107
use std::collections::{HashMap, HashSet};
110108
use std::env;

src/bootstrap/tool.rs

+4-2
Original file line numberDiff line numberDiff line change
@@ -162,13 +162,15 @@ impl Step for ToolBuild {
162162
"the following dependencies are duplicated although they \
163163
have the same features enabled:"
164164
);
165-
for (id, cur, prev) in duplicates.drain_filter(|(_, cur, prev)| cur.2 == prev.2) {
165+
let (same, different): (Vec<_>, Vec<_>) =
166+
duplicates.into_iter().partition(|(_, cur, prev)| cur.2 == prev.2);
167+
for (id, cur, prev) in same {
166168
println!(" {}", id);
167169
// same features
168170
println!(" `{}` ({:?})\n `{}` ({:?})", cur.0, cur.1, prev.0, prev.1);
169171
}
170172
println!("the following dependencies have different features:");
171-
for (id, cur, prev) in duplicates {
173+
for (id, cur, prev) in different {
172174
println!(" {}", id);
173175
let cur_features: HashSet<_> = cur.2.into_iter().collect();
174176
let prev_features: HashSet<_> = prev.2.into_iter().collect();

0 commit comments

Comments
 (0)