Skip to content

Commit 298573c

Browse files
committed
Auto merge of rust-lang#130961 - tgross35:f16-x86-apple, r=<try>
Enable `f16` tests on x86 Apple platforms These were disabled because Apple uses a special ABI for `f16`. `compiler-builtins` merged a fix for this in [1], which has since propagated to rust-lang/rust. Enable tests since there should be no remaining issues on these platforms. [1]: rust-lang/compiler-builtins#675 try-job: x86_64-apple-1 try-job: x86_64-apple-2
2 parents fa724e5 + a51a1e4 commit 298573c

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

library/std/build.rs

+3-7
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,6 @@ fn main() {
105105
("arm64ec", _) => false,
106106
// MinGW ABI bugs <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=115054>
107107
("x86_64", "windows") => false,
108-
// Apple has a special ABI for `f16` that we do not yet support
109-
// FIXME(builtins): fixed by <https://github.com/rust-lang/compiler-builtins/pull/675>
110-
("x86" | "x86_64", _) if target_vendor == "apple" => false,
111108
// Missing `__gnu_h2f_ieee` and `__gnu_f2h_ieee`
112109
("powerpc" | "powerpc64", _) => false,
113110
// Missing `__gnu_h2f_ieee` and `__gnu_f2h_ieee`
@@ -116,10 +113,9 @@ fn main() {
116113
("riscv32" | "riscv64", _) => false,
117114
// Most OSs are missing `__extendhfsf` and `__truncsfhf`
118115
(_, "linux" | "macos") => true,
119-
// Almost all OSs besides Linux and MacOS are missing symbols until compiler-builtins can
120-
// be updated. <https://github.com/rust-lang/rust/pull/125016> will get some of these, the
121-
// next CB update should get the rest.
122-
_ => false,
116+
// todo: only for testing, this line will wind up changed as part of
117+
// <https://github.com/rust-lang/rust/pull/129385>.
118+
_ => true,
123119
};
124120

125121
let has_reliable_f128 = match (target_arch.as_str(), target_os.as_str()) {

0 commit comments

Comments
 (0)