Suggestions

Co-Authored-By: TrolledWoods <[email protected]>

Author: Philippe-Cholet

src/iter_index.rs

@@ -14,7 +14,6 @@ mod private_iter_index {
     impl Sealed for ops::RangeToInclusive<usize> {}
     impl Sealed for ops::RangeFrom<usize> {}
     impl Sealed for ops::RangeFull {}
-    impl Sealed for usize {}
 }
 
 /// Used by the ``range`` function to know which iterator
@@ -53,6 +52,7 @@ where
     type Output = Take<Skip<I>>;
 
     fn index(self, iter: I) -> Self::Output {
+        debug_assert!(!self.is_empty(), "The given `RangeInclusive` is exhausted. The result of indexing with an exhausted `RangeInclusive` is unspecified.");
         iter.skip(*self.start())
             .take((1 + *self.end()).saturating_sub(*self.start()))
     }
@@ -102,17 +102,6 @@ where
     }
 }
 
-impl<I> IteratorIndex<I> for usize
-where
-    I: Iterator,
-{
-    type Output = <Option<I::Item> as IntoIterator>::IntoIter;
-
-    fn index(self, mut iter: I) -> Self::Output {
-        iter.nth(self).into_iter()
-    }
-}
-
 /// Returns an element of the iterator or an iterator
 /// over a subsection of the iterator.
 ///

src/lib.rs

@@ -513,6 +513,9 @@ pub trait Itertools: Iterator {
     /// It's a generalisation of [`take`], [`skip`] and [`nth`], and uses these
     /// under the hood.
     ///
+    /// # Unspecified Behavior
+    /// The result of indexing with an exhausted [`core::ops::RangeInclusive`] is unspecified.
+    ///
     /// # Examples
     ///
     /// ```
@@ -536,9 +539,6 @@ pub trait Itertools: Iterator {
     ///
     /// range = vec.iter().get(..).copied().collect();
     /// assert_eq!(range, vec);
-    ///
-    /// range = vec.iter().get(3).copied().collect();
-    /// assert_eq!(&range, &[1]);
     /// ```
     ///
     /// [`take`]: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.take