Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement core::error::Error #179

Open
michael-p opened this issue Feb 24, 2025 · 2 comments · May be fixed by #180
Open

Implement core::error::Error #179

michael-p opened this issue Feb 24, 2025 · 2 comments · May be fixed by #180

Comments

@michael-p
Copy link

Hey, thanks for your work on this nice library!
I think it would be great if the main error type of the crate would implement core::error::Error, thus making it easier to interoperate with other libraries in the ecosystem. However, this would increase the MSRV to 1.81, and also might pull in some of the formatting machinery in core::fmt.
If you are open to this I can send in a PR.
@thejpster
Copy link
Member

That's a little high for my tastes. Could you put it behind a feature gate?

@michael-p michael-p linked a pull request Feb 25, 2025 that will close this issue
Open
@michael-p
Copy link
Author

Sure - opened #180 for further discussions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement core::error::Error for all error types michael-p/embedded-sdmmc-rs
2 participants
@michael-p @thejpster