Skip to content

Commit e5ca0ae

Browse files
kanishk779kanishk779
committed
Replace Pk with KeyExpr<Pk>
1 parent 102efbd commit e5ca0ae

File tree

17 files changed

+701
-177
lines changed

17 files changed

+701
-177
lines changed

‎src/descriptor/bare.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ use bitcoin::{Address, Network, Script};
2626
use super::checksum::{desc_checksum, verify_checksum};
2727
use crate::expression::{self, FromTree};
2828
use crate::miniscript::context::ScriptContext;
29+
use crate::miniscript::musig_key::KeyExpr;
2930
use crate::policy::{semantic, Liftable};
3031
use crate::prelude::*;
3132
use crate::util::{varint_len, witness_to_scriptsig};
@@ -219,7 +220,7 @@ impl<Pk: MiniscriptKey> Pkh<Pk> {
219220
/// sighash suffix. Includes the weight of the VarInts encoding the
220221
/// scriptSig and witness stack length.
221222
pub fn max_satisfaction_weight(&self) -> usize {
222-
4 * (1 + 73 + BareCtx::pk_len(&self.pk))
223+
4 * (1 + 73 + BareCtx::pk_len(&KeyExpr::SingleKey(self.pk.clone())))
223224
}
224225
}
225226

‎src/descriptor/mod.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ use bitcoin::{self, secp256k1, Address, Network, Script, TxIn};
3434
use sync::Arc;
3535

3636
use self::checksum::verify_checksum;
37+
use crate::miniscript::musig_key::KeyExpr;
3738
use crate::miniscript::{Legacy, Miniscript, Segwitv0};
3839
use crate::prelude::*;
3940
use crate::{
@@ -180,7 +181,7 @@ impl<Pk: MiniscriptKey> Descriptor<Pk> {
180181
// roundabout way to constuct `c:pk_k(pk)`
181182
let ms: Miniscript<Pk, BareCtx> =
182183
Miniscript::from_ast(miniscript::decode::Terminal::Check(Arc::new(
183-
Miniscript::from_ast(miniscript::decode::Terminal::PkK(pk))
184+
Miniscript::from_ast(miniscript::decode::Terminal::PkK(KeyExpr::SingleKey(pk)))
184185
.expect("Type check cannot fail"),
185186
)))
186187
.expect("Type check cannot fail");

‎src/descriptor/segwitv0.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ use super::checksum::{desc_checksum, verify_checksum};
2424
use super::SortedMultiVec;
2525
use crate::expression::{self, FromTree};
2626
use crate::miniscript::context::{ScriptContext, ScriptContextError};
27+
use crate::miniscript::musig_key::KeyExpr;
2728
use crate::policy::{semantic, Liftable};
2829
use crate::prelude::*;
2930
use crate::util::varint_len;
@@ -330,7 +331,7 @@ impl<Pk: MiniscriptKey> Wpkh<Pk> {
330331
/// sighash suffix. Includes the weight of the VarInts encoding the
331332
/// scriptSig and witness stack length.
332333
pub fn max_satisfaction_weight(&self) -> usize {
333-
4 + 1 + 73 + Segwitv0::pk_len(&self.pk)
334+
4 + 1 + 73 + Segwitv0::pk_len(&KeyExpr::SingleKey(self.pk.clone()))
334335
}
335336
}
336337

‎src/descriptor/sortedmulti.rs

+6-1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ use bitcoin::blockdata::script;
2525
use crate::miniscript::context::ScriptContext;
2626
use crate::miniscript::decode::Terminal;
2727
use crate::miniscript::limits::MAX_PUBKEYS_PER_MULTISIG;
28+
use crate::miniscript::musig_key::KeyExpr;
2829
use crate::prelude::*;
2930
use crate::{
3031
errstr, expression, miniscript, policy, script_num_size, Error, ForEachKey, Miniscript,
@@ -183,7 +184,11 @@ impl<Pk: MiniscriptKey, Ctx: ScriptContext> SortedMultiVec<Pk, Ctx> {
183184
script_num_size(self.k)
184185
+ 1
185186
+ script_num_size(self.pks.len())
186-
+ self.pks.iter().map(|pk| Ctx::pk_len(pk)).sum::<usize>()
187+
+ self
188+
.pks
189+
.iter()
190+
.map(|pk| Ctx::pk_len(&KeyExpr::SingleKey(pk.clone())))
191+
.sum::<usize>()
187192
}
188193

189194
/// Maximum number of witness elements used to satisfy the Miniscript

‎src/interpreter/mod.rs

+9-5
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,10 @@ where
593593
Terminal::PkK(ref pk) => {
594594
debug_assert_eq!(node_state.n_evaluated, 0);
595595
debug_assert_eq!(node_state.n_satisfied, 0);
596-
let res = self.stack.evaluate_pk(&mut self.verify_sig, *pk);
596+
let res = match pk.single_key() {
597+
Some(pk) => self.stack.evaluate_pk(&mut self.verify_sig, *pk),
598+
None => None,
599+
};
597600
if res.is_some() {
598601
return res;
599602
}
@@ -868,10 +871,11 @@ where
868871
// evaluate each key with as a pk
869872
// note that evaluate_pk will error on non-empty incorrect sigs
870873
// push 1 on satisfied sigs and push 0 on empty sigs
871-
match self
872-
.stack
873-
.evaluate_pk(&mut self.verify_sig, subs[node_state.n_evaluated])
874-
{
874+
let temp = match subs[node_state.n_evaluated].single_key() {
875+
Some(pkk) => self.stack.evaluate_pk(&mut self.verify_sig, *pkk),
876+
None => None,
877+
};
878+
match temp {
875879
Some(Ok(x)) => {
876880
self.push_evaluation_state(
877881
node_state.node,

‎src/miniscript/astelem.rs

+21-14
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ use bitcoin::blockdata::{opcodes, script};
2626
use sync::Arc;
2727

2828
use crate::miniscript::context::SigType;
29+
use crate::miniscript::musig_key::KeyExpr;
2930
use crate::miniscript::types::{self, Property};
3031
use crate::miniscript::ScriptContext;
3132
use crate::prelude::*;
@@ -80,7 +81,7 @@ impl<Pk: MiniscriptKey, Ctx: ScriptContext> Terminal<Pk, Ctx> {
8081
Pk::RawPkHash: 'a,
8182
{
8283
match *self {
83-
Terminal::PkK(ref p) => pred(p),
84+
Terminal::PkK(ref p) => p.for_each_key(pred),
8485
Terminal::PkH(ref p) => pred(p),
8586
Terminal::RawPkH(..)
8687
| Terminal::After(..)
@@ -112,9 +113,8 @@ impl<Pk: MiniscriptKey, Ctx: ScriptContext> Terminal<Pk, Ctx> {
112113
&& c.real_for_each_key(pred)
113114
}
114115
Terminal::Thresh(_, ref subs) => subs.iter().all(|sub| sub.real_for_each_key(pred)),
115-
Terminal::Multi(_, ref keys) | Terminal::MultiA(_, ref keys) => {
116-
keys.iter().all(|key| pred(key))
117-
}
116+
Terminal::Multi(_, ref keys) => keys.iter().all(|key| pred(key)),
117+
Terminal::MultiA(_, ref keys) => keys.iter().all(|key| key.for_each_key(&mut *pred)),
118118
}
119119
}
120120

@@ -125,7 +125,7 @@ impl<Pk: MiniscriptKey, Ctx: ScriptContext> Terminal<Pk, Ctx> {
125125
T: Translator<Pk, Q, E>,
126126
{
127127
let frag: Terminal<Q, CtxQ> = match *self {
128-
Terminal::PkK(ref p) => Terminal::PkK(t.pk(p)?),
128+
Terminal::PkK(ref p) => Terminal::PkK(p.translate_pk(t)?),
129129
Terminal::PkH(ref p) => Terminal::PkH(t.pk(p)?),
130130
Terminal::RawPkH(ref p) => Terminal::RawPkH(t.pkh(p)?),
131131
Terminal::After(n) => Terminal::After(n),
@@ -186,7 +186,8 @@ impl<Pk: MiniscriptKey, Ctx: ScriptContext> Terminal<Pk, Ctx> {
186186
Terminal::Multi(k, keys?)
187187
}
188188
Terminal::MultiA(k, ref keys) => {
189-
let keys: Result<Vec<Q>, _> = keys.iter().map(|k| t.pk(k)).collect();
189+
let keys: Result<Vec<KeyExpr<Q>>, _> =
190+
keys.iter().map(|k| k.translate_pk(t)).collect();
190191
Terminal::MultiA(k, keys?)
191192
}
192193
};
@@ -455,7 +456,7 @@ impl_from_tree!(
455456
}
456457
let mut unwrapped = match (frag_name, top.args.len()) {
457458
("pk_k", 1) => {
458-
expression::terminal(&top.args[0], |x| Pk::from_str(x).map(Terminal::PkK))
459+
expression::unary(top, Terminal::PkK)
459460
}
460461
("pk_h", 1) => expression::terminal(&top.args[0], |x| Pk::from_str(x).map(Terminal::PkH)),
461462
("after", 1) => expression::terminal(&top.args[0], |x| {
@@ -522,15 +523,18 @@ impl_from_tree!(
522523
return Err(errstr("higher threshold than there were keys in multi"));
523524
}
524525

525-
let pks: Result<Vec<Pk>, _> = top.args[1..]
526-
.iter()
527-
.map(|sub| expression::terminal(sub, Pk::from_str))
528-
.collect();
529-
530526
if frag_name == "multi" {
527+
let pks: Result<Vec<Pk>, _> = top.args[1..]
528+
.iter()
529+
.map(|sub| expression::terminal(sub, Pk::from_str))
530+
.collect();
531531
pks.map(|pks| Terminal::Multi(k, pks))
532532
} else {
533533
// must be multi_a
534+
let pks: Result<Vec<KeyExpr<Pk>>, _> = top.args[1..]
535+
.iter()
536+
.map(|sub| expression::terminal(sub, KeyExpr::<Pk>::from_str))
537+
.collect();
534538
pks.map(|pks| Terminal::MultiA(k, pks))
535539
}
536540
}
@@ -734,7 +738,7 @@ impl<Pk: MiniscriptKey, Ctx: ScriptContext> Terminal<Pk, Ctx> {
734738
builder = builder.push_ms_key::<_, Ctx>(&keys[0]);
735739
builder = builder.push_opcode(opcodes::all::OP_CHECKSIG);
736740
for pk in keys.iter().skip(1) {
737-
builder = builder.push_ms_key::<_, Ctx>(pk);
741+
builder = builder.push_ms_key::<_, Ctx>(&pk);
738742
builder = builder.push_opcode(opcodes::all::OP_CHECKSIGADD);
739743
}
740744
builder
@@ -793,7 +797,10 @@ impl<Pk: MiniscriptKey, Ctx: ScriptContext> Terminal<Pk, Ctx> {
793797
script_num_size(k)
794798
+ 1
795799
+ script_num_size(pks.len())
796-
+ pks.iter().map(|pk| Ctx::pk_len(pk)).sum::<usize>()
800+
+ pks
801+
.iter()
802+
.map(|pk| Ctx::pk_len(&KeyExpr::SingleKey(pk.clone())))
803+
.sum::<usize>()
797804
}
798805
Terminal::MultiA(k, ref pks) => {
799806
script_num_size(k)

0 commit comments

Comments
 (0)