Skip to content

Commit 4527762

Browse files
Merge pull request #174 from runpod/3.8-backwards-compatibility
3.8 backwards compatibility
2 parents f1949ba + a33ec3c commit 4527762

File tree

6 files changed

+10
-13
lines changed

6 files changed

+10
-13
lines changed

.github/workflows/CI-pylint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
lint:
1717
strategy:
1818
matrix:
19-
python-version: [3.9, 3.10.12, 3.11.0]
19+
python-version: [3.8, 3.9, 3.10.12, 3.11.0]
2020
runs-on: ubuntu-latest
2121

2222
steps:

.github/workflows/CI-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
run_tests:
1717
strategy:
1818
matrix:
19-
python-version: [3.9, 3.10.12, 3.11.0]
19+
python-version: [3.8, 3.9, 3.10.12, 3.11.0]
2020
runs-on: ubuntu-latest
2121

2222
steps:

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
### Changes
66

7-
- Backwards compatibility with Python >= 3.9
7+
- Backwards compatibility with Python >= 3.8
88

99
### Fixed
1010

runpod/serverless/utils/rp_cleanup.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@
66

77
import os
88
import shutil
9+
from typing import List
910

1011

11-
def clean(folder_list: list[str] = None):
12+
def clean(folder_list: List[str] = None):
1213
'''
1314
Removes the downloads folder.
1415
'''

setup.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ classifiers =
2727
[options]
2828
include_package_data = true
2929
packages = find:
30-
python_requires = >= 3.9
30+
python_requires = >= 3.8
3131
install_requires =
3232
aiohttp >= 3.8.4
3333
aiohttp-retry >= 2.8.3

tests/test_endpoint/test_asyncio_runner.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,8 @@ async def test_output(self):
3333
'''
3434
Tests Job.output
3535
'''
36-
with (
37-
patch("runpod.endpoint.asyncio.asyncio_runner.asyncio.sleep") as mock_sleep,
38-
patch("aiohttp.ClientSession") as mock_session
39-
):
36+
with patch("runpod.endpoint.asyncio.asyncio_runner.asyncio.sleep") as mock_sleep, \
37+
patch("aiohttp.ClientSession") as mock_session:
4038
mock_resp = MagicMock()
4139

4240
async def json_side_effect():
@@ -69,10 +67,8 @@ async def test_cancel(self):
6967

7068
async def test_output_in_progress_then_completed(self):
7169
'''Tests Job.output when status is initially IN_PROGRESS and then changes to COMPLETED'''
72-
with (
73-
patch("runpod.endpoint.asyncio.asyncio_runner.asyncio.sleep") as mock_sleep,
74-
patch("aiohttp.ClientSession") as mock_session
75-
):
70+
with patch("runpod.endpoint.asyncio.asyncio_runner.asyncio.sleep") as mock_sleep, \
71+
patch("aiohttp.ClientSession") as mock_session:
7672
mock_resp = MagicMock()
7773
responses = [
7874
{"status": "IN_PROGRESS"},

0 commit comments

Comments
 (0)