Skip to content

Commit 2c73cba

Browse files
authored
fix(benchmark): fix benchmark id when creating job with benchmark (#170)
## Description <!-- Provide a brief description of your changes --> - fix benchmark id when creating job with benchmark - update message when creating job <!-- Mark the relevant option with an 'x' --> - [x] Bug fix (non-breaking change which fixes an issue) ## Related Issues <!-- Link to related issues using #issue-number --> Closes # ## Changes Made <!-- Describe the changes in detail --> ## Testing <!-- Describe how you tested your changes --> - [ ] I have tested locally - [ ] I have added/updated tests - [ ] All existing tests pass ## Checklist - [ ] My code follows the code style of this project - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes - [ ] Any dependent changes have been merged and published ## Screenshots (if applicable) <!-- Add screenshots to help explain your changes --> ## Additional Notes <!-- Any additional information that reviewers should know -->
1 parent 123f1d4 commit 2c73cba

File tree

1 file changed

+3
-6
lines changed
  • src/commands/benchmark-job

1 file changed

+3
-6
lines changed

src/commands/benchmark-job/run.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -205,11 +205,8 @@ async function ensureAgentSecrets(
205205

206206
// Resolve benchmark name to ID if needed
207207
async function resolveBenchmarkId(benchmarkIdOrName: string): Promise<string> {
208-
// If it looks like an ID (starts with bm_ or similar), return as-is
209-
if (
210-
benchmarkIdOrName.startsWith("bm_") ||
211-
benchmarkIdOrName.startsWith("bmk_")
212-
) {
208+
// If it looks like a benchmark ID, return as-is
209+
if (benchmarkIdOrName.startsWith("bmd_")) {
213210
return benchmarkIdOrName;
214211
}
215212

@@ -346,7 +343,7 @@ export async function runBenchmarkJob(options: RunOptions) {
346343
console.log(
347344
`Benchmark job created: ${job.id} (agent timeout = ${agentConfigs[0].timeoutSeconds}s)`,
348345
);
349-
console.log(`Follow the run with rli benchmark-job watch ${job.id}`);
346+
console.log(`Follow the run with "rli benchmark-job watch ${job.id}"`);
350347
} else {
351348
output(job, { format: options.output, defaultFormat: "json" });
352349
}

0 commit comments

Comments
 (0)