chore: use FetchContent to download gtest

Author: gautam-rl

CMakeLists.txt

@@ -63,6 +63,17 @@ endif()
 if(BUILD_TESTING)
   enable_testing()
   include(CTest)
+  
+  # Setup googletest
+  include(FetchContent)
+  FetchContent_Declare(
+    googletest
+    GIT_REPOSITORY https://github.com/google/googletest.git
+    GIT_TAG v1.14.0
+  )
+  # For Windows: Prevent overriding the parent project's compiler/linker settings
+  set(gtest_force_shared_crt ON CACHE BOOL "" FORCE)
+  FetchContent_MakeAvailable(googletest)
 endif()
 
 add_subdirectory(src)

src/overlaybd/cache/test/CMakeLists.txt

@@ -1,12 +1,9 @@
 include_directories($ENV{GFLAGS}/include)
 link_directories($ENV{GFLAGS}/lib)
 
-include_directories($ENV{GTEST}/googletest/include)
-link_directories($ENV{GTEST}/lib)
-
 add_executable(cache_test cache_test.cpp)
 target_include_directories(cache_test PUBLIC ${PHOTON_INCLUDE_DIR})
-target_link_libraries(cache_test gtest gtest_main gflags pthread photon_static overlaybd_lib)
+target_link_libraries(cache_test GTest::gtest GTest::gtest_main gflags pthread photon_static overlaybd_lib)
 
 add_test(
   NAME cache_test

src/overlaybd/gzindex/test/CMakeLists.txt

@@ -1,12 +1,10 @@
 include_directories($ENV{GFLAGS}/include)
 link_directories($ENV{GFLAGS}/lib)
 
-include_directories($ENV{GTEST}/googletest/include)
-link_directories($ENV{GTEST}/lib)
 
 add_executable(gzindex_test test.cpp)
 target_include_directories(gzindex_test PUBLIC ${PHOTON_INCLUDE_DIR})
-target_link_libraries(gzindex_test gtest gtest_main gflags pthread photon_static
+target_link_libraries(gzindex_test GTest::gtest GTest::gtest_main gflags pthread photon_static
      gzindex_lib gzip_lib cache_lib checksum_lib)
 
 add_test(

src/overlaybd/lsmt/test/CMakeLists.txt

@@ -1,12 +1,10 @@
 include_directories($ENV{GFLAGS}/include)
 link_directories($ENV{GFLAGS}/lib)
 
-include_directories($ENV{GTEST}/googletest/include)
-link_directories($ENV{GTEST}/lib)
 
 add_executable(lsmt_test test.cpp)
 target_include_directories(lsmt_test PUBLIC ${PHOTON_INCLUDE_DIR})
-target_link_libraries(lsmt_test gtest gtest_main gflags pthread photon_static overlaybd_lib)
+target_link_libraries(lsmt_test GTest::gtest GTest::gtest_main gflags pthread photon_static overlaybd_lib)
 
 add_test(
   NAME lsmt_test

src/overlaybd/tar/erofs/test/CMakeLists.txt

@@ -1,13 +1,11 @@
 include_directories($ENV{GFLAGS}/include)
 link_directories($ENV{GFLAGS}/lib)
 
-include_directories($ENV{GTEST}/googletest/include)
-link_directories($ENV{GTEST}/lib)
 
 # erofs simple test
 add_executable(erofs_simple_test erofs_simple.cpp)
 target_include_directories(erofs_simple_test PUBLIC ${PHOTON_INCLUDE_DIR})
-target_link_libraries(erofs_simple_test gtest gtest_main pthread photon_static
+target_link_libraries(erofs_simple_test GTest::gtest GTest::gtest_main pthread photon_static
   tar_lib lsmt_lib gzip_lib gzindex_lib checksum_lib overlaybd_image_lib)
 
 target_include_directories(erofs_simple_test PUBLIC
@@ -23,7 +21,7 @@ add_test(
 # erofs stress test
 add_executable(erofs_stress_test erofs_stress.cpp erofs_stress_base.cpp)
 target_include_directories(erofs_stress_test PUBLIC ${PHOTON_INCLUDE_DIR})
-target_link_libraries(erofs_stress_test gtest gtest_main pthread photon_static
+target_link_libraries(erofs_stress_test GTest::gtest GTest::gtest_main pthread photon_static
   tar_lib lsmt_lib gzip_lib gzindex_lib checksum_lib overlaybd_image_lib)
 
 target_include_directories(erofs_stress_test PUBLIC

src/overlaybd/tar/test/CMakeLists.txt

@@ -1,12 +1,10 @@
 include_directories($ENV{GFLAGS}/include)
 link_directories($ENV{GFLAGS}/lib)
 
-include_directories($ENV{GTEST}/googletest/include)
-link_directories($ENV{GTEST}/lib)
 
 add_executable(untar_test test.cpp)
 target_include_directories(untar_test PUBLIC ${PHOTON_INCLUDE_DIR})
-target_link_libraries(untar_test gtest gtest_main pthread photon_static
+target_link_libraries(untar_test GTest::gtest GTest::gtest_main pthread photon_static
   tar_lib lsmt_lib gzip_lib gzindex_lib checksum_lib)
 
 add_test(

src/overlaybd/zfile/test/CMakeLists.txt

@@ -2,12 +2,10 @@
 include_directories($ENV{GFLAGS}/include)
 link_directories($ENV{GFLAGS}/lib)
 
-include_directories($ENV{GTEST}/googletest/include)
-link_directories($ENV{GTEST}/lib)
 
 add_executable(zfile_test ./test.cpp)
 
-target_link_libraries(zfile_test gtest gtest_main gflags pthread photon_static overlaybd_lib)
+target_link_libraries(zfile_test GTest::gtest GTest::gtest_main gflags pthread photon_static overlaybd_lib)
 target_include_directories(zfile_test PUBLIC ${PHOTON_INCLUDE_DIR})
 add_test(
   NAME zfile_test

src/test/CMakeLists.txt

@@ -1,15 +1,12 @@
 include_directories($ENV{GFLAGS}/include)
 link_directories($ENV{GFLAGS}/lib)
 
-include_directories($ENV{GTEST}/googletest/include)
-link_directories($ENV{GTEST}/lib)
-
 add_executable(image_service_test image_service_test.cpp)
 target_include_directories(image_service_test PUBLIC
     ${PHOTON_INCLUDE_DIR}
     ${rapidjson_SOURCE_DIR}/include
 )
-target_link_libraries(image_service_test gtest gtest_main gflags pthread photon_static overlaybd_lib overlaybd_image_lib)
+target_link_libraries(image_service_test GTest::gtest GTest::gtest_main gflags pthread photon_static overlaybd_lib overlaybd_image_lib)
 
 add_test(
     NAME image_service_test
@@ -29,21 +26,20 @@ rt
 resolv
 aio
 pthread
-gtest
+GTest::gtest
 )
 
 target_include_directories(simple_credsrv_test PUBLIC
     ${PHOTON_INCLUDE_DIR}
     ${rapidjson_SOURCE_DIR}/include
-    $ENV{GTEST}/googletest/include
 )
 
 add_executable(trace_test trace_test.cpp ../tools/comm_func.cpp)
 target_include_directories(trace_test PUBLIC
     ${PHOTON_INCLUDE_DIR}
     ${rapidjson_SOURCE_DIR}/include
 )
-target_link_libraries(trace_test gtest gtest_main gflags pthread photon_static overlaybd_lib overlaybd_image_lib)
+target_link_libraries(trace_test GTest::gtest GTest::gtest_main gflags pthread photon_static overlaybd_lib overlaybd_image_lib)
 
 add_test(
     NAME trace_test