address comments

Author: sid-rl

src/sdk/scenario-builder.ts

@@ -435,8 +435,8 @@ export class ScenarioBuilder {
   }
 
   private addScorer(name: string, weight: number, scorer: ScoringFunction['scorer']): this {
-    if (weight <= 0) {
-      throw new Error(`Scorer weight must be positive, got ${weight}`);
+    if (!Number.isFinite(weight) || weight <= 0) {
+      throw new Error(`Scorer weight must be a finite positive number, got ${weight}`);
     }
     this._scorers.push({ name, weight, scorer });
     return this;

tests/objects/scenario-builder.test.ts

@@ -185,15 +185,23 @@ describe('ScenarioBuilder', () => {
       expect(() => builder.build()).toThrow('At least one scorer is required');
     });
 
-    it('should throw when scorer weight is not positive', () => {
+    it('should throw when scorer weight is not a finite positive number', () => {
       const builder = new ScenarioBuilder('test', mockClient);
 
       expect(() => builder.addShellCommandScorer('s', { command: 'echo 1', weight: 0 })).toThrow(
-        'Scorer weight must be positive',
+        'Scorer weight must be a finite positive number',
       );
 
       expect(() => builder.addShellCommandScorer('s', { command: 'echo 1', weight: -1 })).toThrow(
-        'Scorer weight must be positive',
+        'Scorer weight must be a finite positive number',
+      );
+
+      expect(() => builder.addShellCommandScorer('s', { command: 'echo 1', weight: NaN })).toThrow(
+        'Scorer weight must be a finite positive number',
+      );
+
+      expect(() => builder.addShellCommandScorer('s', { command: 'echo 1', weight: Infinity })).toThrow(
+        'Scorer weight must be a finite positive number',
       );
     });
   });