Skip to content

Commit a5f52be

Browse files
committed
Resolve feedback
1 parent 295b331 commit a5f52be

File tree

3 files changed

+10
-14
lines changed

3 files changed

+10
-14
lines changed

src/runloop_api_client/resources/devboxes/devboxes.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -668,7 +668,7 @@ def create_tunnel(
668668
timeout: float | httpx.Timeout | None | NotGiven = not_given,
669669
idempotency_key: str | None = None,
670670
) -> DevboxTunnelView:
671-
"""[Deprecated] Use POST /v1/devboxes/{id}/enable_tunnel or devbox creation instead.
671+
"""[Deprecated] Use enable_tunnel or configure a tunnel at devbox creation instead.
672672
673673
This endpoint
674674
creates a legacy tunnel. The new enable_tunnel endpoint provides improved tunnel
@@ -1273,7 +1273,7 @@ def read_file_contents(
12731273
)
12741274

12751275
@typing_extensions.deprecated(
1276-
"remove_tunnel is deprecated; use enable_tunnel or configure a tunnel at devbox creation."
1276+
"remove_tunnel is deprecated; V2 tunnels cannot be removed and close on devbox shutdown."
12771277
)
12781278
def remove_tunnel(
12791279
self,
@@ -1288,7 +1288,7 @@ def remove_tunnel(
12881288
timeout: float | httpx.Timeout | None | NotGiven = not_given,
12891289
idempotency_key: str | None = None,
12901290
) -> object:
1291-
"""[Deprecated] Use enable_tunnel or devbox creation instead.
1291+
"""[Deprecated] V2 tunnels cannot be removed and close on devbox shutdown.
12921292
12931293
This endpoint
12941294
removes a legacy tunnel.
@@ -2281,7 +2281,7 @@ async def create_tunnel(
22812281
timeout: float | httpx.Timeout | None | NotGiven = not_given,
22822282
idempotency_key: str | None = None,
22832283
) -> DevboxTunnelView:
2284-
"""[Deprecated] Use POST /v1/devboxes/{id}/enable_tunnel or devbox creation instead.
2284+
"""[Deprecated] Use enable_tunnel or configure a tunnel at devbox creation instead.
22852285
22862286
This endpoint
22872287
creates a legacy tunnel. The new enable_tunnel endpoint provides improved tunnel
@@ -2889,7 +2889,7 @@ async def read_file_contents(
28892889
)
28902890

28912891
@typing_extensions.deprecated(
2892-
"remove_tunnel is deprecated; use enable_tunnel or configure a tunnel at devbox creation."
2892+
"remove_tunnel is deprecated; V2 tunnels cannot be removed and close on devbox shutdown."
28932893
)
28942894
async def remove_tunnel(
28952895
self,
@@ -2904,7 +2904,7 @@ async def remove_tunnel(
29042904
timeout: float | httpx.Timeout | None | NotGiven = not_given,
29052905
idempotency_key: str | None = None,
29062906
) -> object:
2907-
"""[Deprecated] Use enable_tunnel or devbox creation instead.
2907+
"""[Deprecated] V2 tunnels cannot be removed and close on devbox shutdown.
29082908
29092909
This endpoint
29102910
removes a legacy tunnel.

src/runloop_api_client/sdk/async_devbox.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -829,9 +829,7 @@ async def remove_tunnel(
829829
self,
830830
**params: Unpack[SDKDevboxRemoveTunnelParams],
831831
) -> object:
832-
"""[Deprecated] Remove a legacy network tunnel.
833-
834-
Use :meth:`enable_tunnel` or configure a tunnel during devbox creation instead.
832+
"""[Deprecated] V2 tunnels cannot be removed and close on devbox shutdown.
835833
836834
:param params: See :typeddict:`~runloop_api_client.sdk._types.SDKDevboxRemoveTunnelParams` for available parameters
837835
:return: Response confirming the tunnel removal
@@ -841,7 +839,7 @@ async def remove_tunnel(
841839
>>> await devbox.net.remove_tunnel(port=8080)
842840
"""
843841
warnings.warn(
844-
"remove_tunnel is deprecated; use enable_tunnel or configure a tunnel at devbox creation.",
842+
"remove_tunnel is deprecated; V2 tunnels cannot be removed and close on devbox shutdown.",
845843
DeprecationWarning,
846844
stacklevel=2,
847845
)

src/runloop_api_client/sdk/devbox.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -832,9 +832,7 @@ def remove_tunnel(
832832
self,
833833
**params: Unpack[SDKDevboxRemoveTunnelParams],
834834
) -> object:
835-
"""[Deprecated] Remove a legacy network tunnel.
836-
837-
Use :meth:`enable_tunnel` or configure a tunnel during devbox creation instead.
835+
"""[Deprecated] V2 tunnels cannot be removed and close on devbox shutdown.
838836
839837
:param params: See :typeddict:`~runloop_api_client.sdk._types.SDKDevboxRemoveTunnelParams` for available parameters
840838
:return: Response confirming the tunnel removal
@@ -844,7 +842,7 @@ def remove_tunnel(
844842
>>> devbox.net.remove_tunnel(port=8080)
845843
"""
846844
warnings.warn(
847-
"remove_tunnel is deprecated; use enable_tunnel or configure a tunnel at devbox creation.",
845+
"remove_tunnel is deprecated; V2 tunnels cannot be removed and close on devbox shutdown.",
848846
DeprecationWarning,
849847
stacklevel=2,
850848
)

0 commit comments

Comments
 (0)