Skip to content

Commit 925c735

Browse files
authored
fix(sdk): remove incorrect remove_tunnel DeprecationWarning (#775)
1 parent 1ddf564 commit 925c735

5 files changed

Lines changed: 23 additions & 42 deletions

File tree

src/runloop_api_client/sdk/async_devbox.py

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import asyncio
66
import logging
7-
import warnings
87
from typing import TYPE_CHECKING, Any, Callable, Optional, Sequence, Awaitable, cast
98
from typing_extensions import Unpack, override
109

@@ -835,7 +834,7 @@ async def remove_tunnel(
835834
self,
836835
**params: Unpack[SDKDevboxRemoveTunnelParams],
837836
) -> object:
838-
"""[Deprecated] V2 tunnels cannot be removed and close on devbox shutdown.
837+
"""Remove a tunnel from the devbox.
839838
840839
:param params: See :typeddict:`~runloop_api_client.sdk._types.SDKDevboxRemoveTunnelParams` for available parameters
841840
:return: Response confirming the tunnel removal
@@ -844,14 +843,7 @@ async def remove_tunnel(
844843
Example:
845844
>>> await devbox.net.remove_tunnel()
846845
"""
847-
warnings.warn(
848-
"remove_tunnel is deprecated; V2 tunnels cannot be removed and close on devbox shutdown.",
849-
DeprecationWarning,
850-
stacklevel=2,
846+
return await self._devbox._client.devboxes.remove_tunnel(
847+
self._devbox.id,
848+
**params,
851849
)
852-
with warnings.catch_warnings():
853-
warnings.simplefilter("ignore", DeprecationWarning)
854-
return await self._devbox._client.devboxes.remove_tunnel( # type: ignore[deprecated]
855-
self._devbox.id,
856-
**params,
857-
)

src/runloop_api_client/sdk/devbox.py

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
from __future__ import annotations
44

55
import logging
6-
import warnings
76
import threading
87
from typing import TYPE_CHECKING, Any, Callable, Optional, Sequence
98
from typing_extensions import Unpack, override
@@ -838,7 +837,7 @@ def remove_tunnel(
838837
self,
839838
**params: Unpack[SDKDevboxRemoveTunnelParams],
840839
) -> object:
841-
"""[Deprecated] V2 tunnels cannot be removed and close on devbox shutdown.
840+
"""Remove a tunnel from the devbox.
842841
843842
:param params: See :typeddict:`~runloop_api_client.sdk._types.SDKDevboxRemoveTunnelParams` for available parameters
844843
:return: Response confirming the tunnel removal
@@ -847,14 +846,7 @@ def remove_tunnel(
847846
Example:
848847
>>> devbox.net.remove_tunnel()
849848
"""
850-
warnings.warn(
851-
"remove_tunnel is deprecated; V2 tunnels cannot be removed and close on devbox shutdown.",
852-
DeprecationWarning,
853-
stacklevel=2,
849+
return self._devbox._client.devboxes.remove_tunnel(
850+
self._devbox.id,
851+
**params,
854852
)
855-
with warnings.catch_warnings():
856-
warnings.simplefilter("ignore", DeprecationWarning)
857-
return self._devbox._client.devboxes.remove_tunnel( # type: ignore[deprecated]
858-
self._devbox.id,
859-
**params,
860-
)

tests/sdk/async_devbox/test_interfaces.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -184,14 +184,13 @@ async def test_remove_tunnel(self, mock_async_client: AsyncMock) -> None:
184184
mock_async_client.devboxes.remove_tunnel = AsyncMock(return_value=object())
185185

186186
devbox = AsyncDevbox(mock_async_client, "dbx_123")
187-
with pytest.warns(DeprecationWarning, match="remove_tunnel is deprecated"):
188-
result = await devbox.net.remove_tunnel(
189-
extra_headers={"X-Custom": "value"},
190-
extra_query={"param": "value"},
191-
extra_body={"key": "value"},
192-
timeout=30.0,
193-
idempotency_key="key-123",
194-
)
187+
result = await devbox.net.remove_tunnel(
188+
extra_headers={"X-Custom": "value"},
189+
extra_query={"param": "value"},
190+
extra_body={"key": "value"},
191+
timeout=30.0,
192+
idempotency_key="key-123",
193+
)
195194

196195
assert result is not None # Verify return value is propagated
197196
mock_async_client.devboxes.remove_tunnel.assert_called_once()

tests/sdk/devbox/test_interfaces.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
from unittest.mock import Mock
1212

1313
import httpx
14-
import pytest
1514

1615
from tests.sdk.conftest import MockExecutionView
1716
from runloop_api_client.sdk import Devbox
@@ -285,14 +284,13 @@ def test_remove_tunnel(self, mock_client: Mock) -> None:
285284
mock_client.devboxes.remove_tunnel.return_value = object()
286285

287286
devbox = Devbox(mock_client, "dbx_123")
288-
with pytest.warns(DeprecationWarning, match="remove_tunnel is deprecated"):
289-
result = devbox.net.remove_tunnel(
290-
extra_headers={"X-Custom": "value"},
291-
extra_query={"param": "value"},
292-
extra_body={"key": "value"},
293-
timeout=30.0,
294-
idempotency_key="key-123",
295-
)
287+
result = devbox.net.remove_tunnel(
288+
extra_headers={"X-Custom": "value"},
289+
extra_query={"param": "value"},
290+
extra_body={"key": "value"},
291+
timeout=30.0,
292+
idempotency_key="key-123",
293+
)
296294

297295
assert result is not None # Verify return value is propagated
298296
mock_client.devboxes.remove_tunnel.assert_called_once_with(

uv.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)