Skip to content

Commit 6d3e819

Browse files
committed
add maintainence comments for manually edited types files
1 parent 3528296 commit 6d3e819

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

src/runloop_api_client/types/devbox_create_params.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,14 @@
1111

1212
__all__ = ["DevboxCreateParams"]
1313

14+
# We split up the original DevboxCreateParams into two nested classes to enable us to
15+
# omit blueprint_id, blueprint_name, and snapshot_id when we unpack the TypedDict
16+
# params for methods like create_from_blueprint_id, create_from_blueprint_name, and
17+
# create_from_snapshot, which shouldn't allow you to specify creation source kwargs.
1418

19+
20+
# DevboxBaseCreateParams should contain all the fields that are common to all the
21+
# create methods. Any updates to the OpenAPI spec should be reflected here.
1522
class DevboxBaseCreateParams(TypedDict, total=False):
1623
code_mounts: Optional[Iterable[CodeMountParameters]]
1724
"""A list of code mounts to be included in the Devbox."""
@@ -53,6 +60,8 @@ class DevboxBaseCreateParams(TypedDict, total=False):
5360
"""
5461

5562

63+
# DevboxCreateParams should only implement fields that specify the devbox creation source.
64+
# These are omitted from specialized create methods.
5665
class DevboxCreateParams(DevboxBaseCreateParams, total=False):
5766
blueprint_id: Optional[str]
5867
"""Blueprint ID to use for the Devbox.

src/runloop_api_client/types/object_create_params.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
__all__ = ["ObjectCreateParams"]
99

1010

11+
# We manually define the content type here to use as a type hint in the SDK.
12+
# If the API supports new content types, update this list accordingly.
1113
ContentType = Literal["unspecified", "text", "binary", "gzip", "tar", "tgz"]
1214

1315

0 commit comments

Comments
 (0)