lint

Author: alb-rl

src/runloop_api_client/sdk/async_blueprint.py

@@ -101,4 +101,4 @@ async def create_devbox(
             blueprint_id=self._id,
             **params,
         )
-        return AsyncDevbox(self._client, devbox_view.id)
+        return AsyncDevbox(self._client, devbox_view)

src/runloop_api_client/sdk/async_scenario_run.py

@@ -4,7 +4,6 @@
 
 import os
 from typing import Union, Optional
-from functools import cached_property
 from typing_extensions import Unpack, override
 
 from ..types import ScenarioRunView
@@ -68,16 +67,16 @@ def devbox_id(self) -> str:
         """
         return self._devbox_id
 
-    @cached_property
-    def devbox(self) -> AsyncDevbox:
-        """The devbox instance for this scenario run.
+    async def get_devbox(self) -> AsyncDevbox:
+        """Get the devbox instance for this scenario run.
 
         Use this to interact with the devbox environment during the scenario run.
 
         :return: AsyncDevbox instance
         :rtype: AsyncDevbox
         """
-        return AsyncDevbox(self._client, self._devbox_id)
+        devbox_view = await self._client.devboxes.retrieve(self._devbox_id)
+        return AsyncDevbox(self._client, devbox_view)
 
     async def get_info(
         self,

src/runloop_api_client/sdk/async_snapshot.py

@@ -122,4 +122,4 @@ async def create_devbox(
             snapshot_id=self._id,
             **params,
         )
-        return AsyncDevbox(self._client, devbox_view.id)
+        return AsyncDevbox(self._client, devbox_view)

src/runloop_api_client/sdk/blueprint.py

@@ -101,4 +101,4 @@ def create_devbox(
             blueprint_id=self._id,
             **params,
         )
-        return Devbox(self._client, devbox_view.id)
+        return Devbox(self._client, devbox_view)

src/runloop_api_client/sdk/scenario_run.py

@@ -77,7 +77,8 @@ def devbox(self) -> Devbox:
         :return: Devbox instance
         :rtype: Devbox
         """
-        return Devbox(self._client, self._devbox_id)
+        devbox_view = self._client.devboxes.retrieve(self._devbox_id)
+        return Devbox(self._client, devbox_view)
 
     def get_info(
         self,

src/runloop_api_client/sdk/snapshot.py

@@ -122,4 +122,4 @@ def create_devbox(
             snapshot_id=self._id,
             **params,
         )
-        return Devbox(self._client, devbox_view.id)
+        return Devbox(self._client, devbox_view)

tests/sdk/async_devbox/test_core.py

@@ -11,7 +11,7 @@
 
 import pytest
 
-from tests.sdk.conftest import MockDevboxView
+from tests.sdk.conftest import MockDevboxView, mock_devbox_view
 from runloop_api_client.sdk import AsyncDevbox
 from runloop_api_client.lib.polling import PollingConfig
 from runloop_api_client.sdk.async_devbox import (
@@ -26,20 +26,20 @@ class TestAsyncDevbox:
 
     def test_init(self, mock_async_client: AsyncMock) -> None:
         """Test AsyncDevbox initialization."""
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         assert devbox.id == "dbx_123"
 
     def test_repr(self, mock_async_client: AsyncMock) -> None:
         """Test AsyncDevbox string representation."""
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         assert repr(devbox) == "<AsyncDevbox id='dbx_123'>"
 
     @pytest.mark.asyncio
     async def test_context_manager_enter_exit(self, mock_async_client: AsyncMock, devbox_view: MockDevboxView) -> None:
         """Test context manager behavior with successful shutdown."""
         mock_async_client.devboxes.shutdown = AsyncMock(return_value=devbox_view)
 
-        async with AsyncDevbox(mock_async_client, "dbx_123") as devbox:
+        async with AsyncDevbox(mock_async_client, mock_devbox_view()) as devbox:
             assert devbox.id == "dbx_123"
 
         call_kwargs = mock_async_client.devboxes.shutdown.call_args[1]
@@ -51,7 +51,7 @@ async def test_context_manager_exception_handling(self, mock_async_client: Async
         mock_async_client.devboxes.shutdown = AsyncMock(side_effect=RuntimeError("Shutdown failed"))
 
         with pytest.raises(ValueError, match="Test error"):
-            async with AsyncDevbox(mock_async_client, "dbx_123"):
+            async with AsyncDevbox(mock_async_client, mock_devbox_view()):
                 raise ValueError("Test error")
 
         # Shutdown should be called even when body raises exception
@@ -62,7 +62,7 @@ async def test_get_info(self, mock_async_client: AsyncMock, devbox_view: MockDev
         """Test get_info method."""
         mock_async_client.devboxes.retrieve = AsyncMock(return_value=devbox_view)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.get_info(
             extra_headers={"X-Custom": "value"},
             extra_query={"param": "value"},
@@ -85,7 +85,7 @@ async def test_await_running(self, mock_async_client: AsyncMock, devbox_view: Mo
         mock_async_client.devboxes.await_running = AsyncMock(return_value=devbox_view)
         polling_config = PollingConfig(timeout_seconds=60.0)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.await_running(polling_config=polling_config)
 
         assert result == devbox_view
@@ -100,7 +100,7 @@ async def test_await_suspended(self, mock_async_client: AsyncMock, devbox_view:
         mock_async_client.devboxes.await_suspended = AsyncMock(return_value=devbox_view)
         polling_config = PollingConfig(timeout_seconds=60.0)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.await_suspended(polling_config=polling_config)
 
         assert result == devbox_view
@@ -114,7 +114,7 @@ async def test_shutdown(self, mock_async_client: AsyncMock, devbox_view: MockDev
         """Test shutdown method."""
         mock_async_client.devboxes.shutdown = AsyncMock(return_value=devbox_view)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.shutdown(
             extra_headers={"X-Custom": "value"},
             extra_query={"param": "value"},
@@ -138,7 +138,7 @@ async def test_suspend(self, mock_async_client: AsyncMock, devbox_view: MockDevb
         """Test suspend method."""
         mock_async_client.devboxes.suspend = AsyncMock(return_value=devbox_view)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.suspend(
             extra_headers={"X-Custom": "value"},
             extra_query={"param": "value"},
@@ -164,7 +164,7 @@ async def test_resume(self, mock_async_client: AsyncMock, devbox_view: MockDevbo
         mock_async_client.devboxes.await_running = AsyncMock(return_value=devbox_view)
         polling_config = PollingConfig(timeout_seconds=60.0)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.resume(
             polling_config=polling_config,
             extra_headers={"X-Custom": "value"},
@@ -193,7 +193,7 @@ async def test_resume_async(self, mock_async_client: AsyncMock, devbox_view: Moc
         """Test resume_async method."""
         mock_async_client.devboxes.resume = AsyncMock(return_value=devbox_view)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.resume_async(
             extra_headers={"X-Custom": "value"},
             extra_query={"param": "value"},
@@ -217,7 +217,7 @@ async def test_keep_alive(self, mock_async_client: AsyncMock) -> None:
         """Test keep_alive method."""
         mock_async_client.devboxes.keep_alive = AsyncMock(return_value=object())
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.keep_alive(
             extra_headers={"X-Custom": "value"},
             extra_query={"param": "value"},
@@ -245,7 +245,7 @@ async def test_snapshot_disk(self, mock_async_client: AsyncMock) -> None:
         mock_async_client.devboxes.snapshot_disk_async = AsyncMock(return_value=snapshot_data)
         mock_async_client.devboxes.disk_snapshots.await_completed = AsyncMock(return_value=snapshot_status)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         polling_config = PollingConfig(timeout_seconds=60.0)
         snapshot = await devbox.snapshot_disk(
             name="test-snapshot",
@@ -274,7 +274,7 @@ async def test_snapshot_disk_async(self, mock_async_client: AsyncMock) -> None:
         snapshot_data = SimpleNamespace(id="snp_123")
         mock_async_client.devboxes.snapshot_disk_async = AsyncMock(return_value=snapshot_data)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         snapshot = await devbox.snapshot_disk_async(
             name="test-snapshot",
             metadata={"key": "value"},
@@ -296,7 +296,7 @@ async def test_close(self, mock_async_client: AsyncMock, devbox_view: MockDevbox
         """Test close method calls shutdown."""
         mock_async_client.devboxes.shutdown = AsyncMock(return_value=devbox_view)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         await devbox.close()
 
         mock_async_client.devboxes.shutdown.assert_called_once()
@@ -305,21 +305,21 @@ async def test_close(self, mock_async_client: AsyncMock, devbox_view: MockDevbox
 
     def test_cmd_property(self, mock_async_client: AsyncMock) -> None:
         """Test cmd property returns AsyncCommandInterface."""
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         cmd = devbox.cmd
         assert isinstance(cmd, AsyncCommandInterface)
         assert cmd._devbox is devbox
 
     def test_file_property(self, mock_async_client: AsyncMock) -> None:
         """Test file property returns AsyncFileInterface."""
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         file_interface = devbox.file
         assert isinstance(file_interface, AsyncFileInterface)
         assert file_interface._devbox is devbox
 
     def test_net_property(self, mock_async_client: AsyncMock) -> None:
         """Test net property returns AsyncNetworkInterface."""
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         net = devbox.net
         assert isinstance(net, AsyncNetworkInterface)
         assert net._devbox is devbox

tests/sdk/async_devbox/test_edge_cases.py

@@ -10,6 +10,7 @@
 import httpx
 import pytest
 
+from tests.sdk.conftest import mock_devbox_view
 from runloop_api_client.sdk import AsyncDevbox
 
 
@@ -21,6 +22,6 @@ async def test_async_network_error(self, mock_async_client: AsyncMock) -> None:
         """Test handling of network errors in async."""
         mock_async_client.devboxes.retrieve = AsyncMock(side_effect=httpx.NetworkError("Connection failed"))
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         with pytest.raises(httpx.NetworkError):
             await devbox.get_info()

tests/sdk/async_devbox/test_interfaces.py

@@ -12,7 +12,7 @@
 import httpx
 import pytest
 
-from tests.sdk.conftest import MockExecutionView
+from tests.sdk.conftest import MockExecutionView, mock_devbox_view
 from runloop_api_client.sdk import AsyncDevbox
 
 
@@ -27,7 +27,7 @@ async def test_exec_without_callbacks(
         mock_async_client.devboxes.execute_async = AsyncMock(return_value=execution_view)
         mock_async_client.devboxes.executions.await_completed = AsyncMock(return_value=execution_view)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.cmd.exec("echo hello")
 
         assert result.exit_code == 0
@@ -61,7 +61,7 @@ async def test_exec_with_stdout_callback(self, mock_async_client: AsyncMock, moc
 
         stdout_calls: list[str] = []
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.cmd.exec("echo hello", stdout=stdout_calls.append)
 
         assert result.exit_code == 0
@@ -81,7 +81,7 @@ async def test_exec_async_returns_execution(
         mock_async_client.devboxes.execute_async = AsyncMock(return_value=execution_async)
         mock_async_client.devboxes.executions.stream_stdout_updates = AsyncMock(return_value=mock_async_stream)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         execution = await devbox.cmd.exec_async("long-running command")
 
         assert execution.execution_id == "exn_123"
@@ -97,7 +97,7 @@ async def test_read(self, mock_async_client: AsyncMock) -> None:
         """Test file read."""
         mock_async_client.devboxes.read_file_contents = AsyncMock(return_value="file content")
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.file.read(file_path="/path/to/file")
 
         assert result == "file content"
@@ -109,7 +109,7 @@ async def test_write_string(self, mock_async_client: AsyncMock) -> None:
         execution_detail = SimpleNamespace()
         mock_async_client.devboxes.write_file_contents = AsyncMock(return_value=execution_detail)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.file.write(file_path="/path/to/file", contents="content")
 
         assert result == execution_detail
@@ -121,7 +121,7 @@ async def test_write_bytes(self, mock_async_client: AsyncMock) -> None:
         execution_detail = SimpleNamespace()
         mock_async_client.devboxes.write_file_contents = AsyncMock(return_value=execution_detail)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.file.write(file_path="/path/to/file", contents="content")
 
         assert result == execution_detail
@@ -134,7 +134,7 @@ async def test_download(self, mock_async_client: AsyncMock) -> None:
         mock_response.read = AsyncMock(return_value=b"file content")
         mock_async_client.devboxes.download_file = AsyncMock(return_value=mock_response)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.file.download(path="/path/to/file")
 
         assert result == b"file content"
@@ -146,7 +146,7 @@ async def test_upload(self, mock_async_client: AsyncMock, tmp_path: Path) -> Non
         execution_detail = SimpleNamespace()
         mock_async_client.devboxes.upload_file = AsyncMock(return_value=execution_detail)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         # Create a temporary file for upload
         temp_file = tmp_path / "test_file.txt"
         temp_file.write_text("test content")
@@ -166,7 +166,7 @@ async def test_create_ssh_key(self, mock_async_client: AsyncMock) -> None:
         ssh_key_response = SimpleNamespace(public_key="ssh-rsa ...")
         mock_async_client.devboxes.create_ssh_key = AsyncMock(return_value=ssh_key_response)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.net.create_ssh_key(
             extra_headers={"X-Custom": "value"},
             extra_query={"param": "value"},
@@ -184,7 +184,7 @@ async def test_create_tunnel(self, mock_async_client: AsyncMock) -> None:
         tunnel_view = SimpleNamespace(tunnel_id="tunnel_123")
         mock_async_client.devboxes.create_tunnel = AsyncMock(return_value=tunnel_view)
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.net.create_tunnel(
             port=8080,
             extra_headers={"X-Custom": "value"},
@@ -202,7 +202,7 @@ async def test_remove_tunnel(self, mock_async_client: AsyncMock) -> None:
         """Test remove tunnel."""
         mock_async_client.devboxes.remove_tunnel = AsyncMock(return_value=object())
 
-        devbox = AsyncDevbox(mock_async_client, "dbx_123")
+        devbox = AsyncDevbox(mock_async_client, mock_devbox_view())
         result = await devbox.net.remove_tunnel(
             port=8080,
             extra_headers={"X-Custom": "value"},