[WIP] Support overlaybd image format instead of OCI#25
Draft
yoon-park-rl wants to merge 6 commits intomainfrom
Draft
[WIP] Support overlaybd image format instead of OCI#25yoon-park-rl wants to merge 6 commits intomainfrom
yoon-park-rl wants to merge 6 commits intomainfrom
Conversation
37072ac to
94dc5ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
overlaybd-snapshotter cannot created overalybd snapshot when the Dockerfile depends on OCI image.
Problem Detail
Currently overlaybd-snapshotter can create overlaybd image on the top of OCI image, which is not working. The blueprint image format looks like below.

If it's working, the blueprint image format looks like this

As you can see, it should shows overlaybd annotation.
Root Cause
Here is the buildkit open source.
https://github.com/moby/buildkit/blob/master/cache/blobs.go#L190-L202
Currently, Runloop uses overlaybd snapshooter whose name is "overlaybd". buildkit open sources probably assumes it's not overlaybd image, because of this line of code.
if bdPath := snStat.Labels[obdlabel.LocalOverlayBDPath]; bdPath != "" {What does this PR do
This PR supports to support the issue above.
What's the limitation of this PR
This PR attach overlaybd annotation onto the image format. However, first layer doesn't contain it.

What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: