Unnecessary Warning

[Roba1993]

From my perspective the following warning is not really valid?

warning: Warning
   ┌─ script:51:9
   │  
47 │   fn get_causes(causes) {
   │ ╭───────────────────────'
48 │ │     let top = #{};
49 │ │     let bottom = #{};
50 │ │ 
51 │ │     for (i, (k, v)) in causes.iter().enumerate() {
   │ │         ^^^^^^^^^^^ Pattern might panic
   · │
65 │ │     html
66 │ │ }
   │ ╰─' In this context
   │  
   = Hint: Rewrite to:
     if (i, (k, v)) {
         // ..
     }

[barries]

Here's another way of causing that error.

To me, from most to least important:

a. an actual failure to destructure at runtime should be a runtime error and diagnostic, not a panic (independent of the lint warning).

b.for destructuring args and iterators at least, this warning should either:

(b1) on by default and be silence-able inline (à la Rust's #[allow(...)]), which is my preference because it leads to better code and documenting potential failure points for maintainers, or

(b2) not be on by default because dynamic typing always runs the risk of runtime type mismatches and often (usually?) there's no feasible fallback other than erroring out, it's just defective data. In this case it can be very nice to ask compilers and VMs for more pedantic warnings (à la gcc -pedantic) so that devs can find places where there

c. that hint doesn't look like valid code and I tried to follow it and got a syntactic error.

d. It would also be nice(tm) if the hint explained how to typecheck in these destructuring scenarios; that if can't be slapped into the code in this scenario or in OP's scenario above.

    #{}
        .iter()
        .map(|(array_name, array)| 0);

Generated warning:

warning: Warning
   ┌─ postprocess_AD_Protocol_Spec.md.rhai:24:15
   │
24 │         .map(|(array_name, array)| 0);
   │               ^^^^^^^^^^^^^^^^^^^  - In this context
   │               │                     
   │               Pattern might panic
   │
   = Hint: Rewrite to:
     if (array_name, array) {
         // ..
     }