Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support a list of unsafe commands #23

Closed
alaypatel07 opened this issue Jun 16, 2022 · 4 comments
Closed

support a list of unsafe commands #23

alaypatel07 opened this issue Jun 16, 2022 · 4 comments

Comments

@alaypatel07
Copy link

Thanks for this awesome plugin.

I was wondering a KUBECTL_UNSAFE_COMMANDS variable can be supported.

The need I have is to only block delete command, and I do not want to keep my list up to date anytime a new command is added to kubectl
@rumstead
Copy link
Owner

Definitely!

rumstead added a commit that referenced this issue Jun 17, 2022
@rumstead
feat(unsafe): closes #23
8264eb9
@rumstead
Copy link
Owner

rumstead commented Jun 17, 2022 •
edited
Loading

@alaypatel07 can you confirm it works as expected? Then I will publish the new version.

@alaypatel07
Copy link
Author

@rumstead thanks for the quick turnaround, I will test it and get back to you.

@alaypatel07
Copy link
Author

Hi @rumstead #24 (review) added my verification to the PRR. Before you cut a new release, can you please look at #25 and let me know what you think? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alaypatel07 @rumstead