Clean up some comments. Also use a point for extusion side faces from the original line.

Author: phkahler

src/group.cpp

@@ -899,10 +899,8 @@ void Group::MakeExtrusionLines(EntityList *el, hEntity in) {
         en.param[1] = h.param(1);
         en.param[2] = h.param(2);
         en.numPoint = a;
-        // might use the original point, not the remapped one - but surface face uses TOP
-        // using the original point might allow face dragging the sides unconstrained extrusions
-        en.point[0] = Remap(ep->point[0], REMAP_TOP);
-//        en.point[0] = ep->point[0];
+        // we need a point somewhere on the face. Use one from the original line.
+        en.point[0] = ep->point[0];        
         en.numNormal = Quaternion::From(0, ab.x, ab.y, ab.z);
 
         en.group = h;
@@ -1188,6 +1186,7 @@ void Group::CopyEntity(EntityList *el,
             }
             en.numPoint  = (ep->actPoint).ScaledBy(scale);
             en.numNormal = (ep->actNormal).ScaledBy(scale);
+            // the new face needs an associated point
             en.point[0] = Remap(ep->point[0], remap);
             break;
 

src/mouse.cpp

@@ -65,14 +65,17 @@ void GraphicsWindow::StartDraggingByEntity(hEntity he) {
             AddPointToDraggedList(e->point[i]);
         }
     } else if(e->type == Entity::Type::FACE_NORMAL_PT
-             || e->type == Entity::Type::FACE_N_TRANS           // translate groups work fine
-//             || e->type == Entity::Type::FACE_N_ROT_AA        // rotate groups are unstable dragging
+             || e->type == Entity::Type::FACE_N_TRANS             // this is for translate groups
+
+            // rotate groups are currently unstable dragging
+//             || e->type == Entity::Type::FACE_N_ROT_AA        
 
-//           || e->type == Entity::Type::FACE_ROT_NORMAL_PT ) {   // needed for helix and revolve
 // Revolve is unstable because the point is on axis. Helix drags in axial direction for same reason
+//           || e->type == Entity::Type::FACE_ROT_NORMAL_PT ) {     // needed for helix and revolve
 
-           || e->type == Entity::Type::FACE_N_ROT_TRANS) {      // needed for linked objects
-// Linking fails with old files because faces did not set point[0] prior to version 3.2
+           || e->type == Entity::Type::FACE_N_ROT_TRANS) {        // needed for linked objects
+        // Files save prior to v3.2 didn't specify point[0]
+        // so check existence before using it.
         if(SK.entity.FindByIdNoOops(e->point[0]))
         {
           AddPointToDraggedList(e->point[0]);

test/group/translate_asy/normal.slvs

@@ -259,6 +259,14 @@ Group.remap={
     127 8003002b 1000
     128 8003002c 1000
     129 8003002d 1000
+    130 00040001 0
+    131 00050001 0
+    132 00060001 0
+    133 00070001 0
+    134 00040001 1000
+    135 00050001 1000
+    136 00060001 1000
+    137 00070001 1000
 }
 AddGroup
 
@@ -721,7 +729,7 @@ AddEntity
 Entity.h.v=80030007
 Entity.type=5001
 Entity.construction=0
-Entity.point[0].v=80030005
+Entity.point[0].v=00040001
 Entity.actPoint.x=10.00000000000000000000
 Entity.actPoint.y=-5.00000000000000000000
 Entity.actNormal.vx=-1.00000000000000000000
@@ -797,7 +805,7 @@ AddEntity
 Entity.h.v=80030010
 Entity.type=5001
 Entity.construction=0
-Entity.point[0].v=8003000e
+Entity.point[0].v=00050001
 Entity.actPoint.x=-5.00000000000000000000
 Entity.actPoint.y=-5.00000000000000000000
 Entity.actNormal.vy=1.00000000000000000000
@@ -873,7 +881,7 @@ AddEntity
 Entity.h.v=80030019
 Entity.type=5001
 Entity.construction=0
-Entity.point[0].v=80030017
+Entity.point[0].v=00060001
 Entity.actPoint.x=-5.00000000000000000000
 Entity.actPoint.y=5.00000000000000000000
 Entity.actNormal.vx=1.00000000000000000000
@@ -949,7 +957,7 @@ AddEntity
 Entity.h.v=80030022
 Entity.type=5001
 Entity.construction=0
-Entity.point[0].v=80030020
+Entity.point[0].v=00070001
 Entity.actPoint.x=10.00000000000000000000
 Entity.actPoint.y=5.00000000000000000000
 Entity.actNormal.vy=-1.00000000000000000000
@@ -1079,7 +1087,7 @@ AddEntity
 Entity.h.v=80040007
 Entity.type=5003
 Entity.construction=0
-Entity.point[0].v=80040005
+Entity.point[0].v=80040082
 Entity.actPoint.x=10.00000000000000000000
 Entity.actPoint.y=-5.00000000000000000000
 Entity.actNormal.vx=-1.00000000000000000000
@@ -1155,7 +1163,7 @@ AddEntity
 Entity.h.v=80040010
 Entity.type=5003
 Entity.construction=0
-Entity.point[0].v=8004000e
+Entity.point[0].v=80040083
 Entity.actPoint.x=-5.00000000000000000000
 Entity.actPoint.y=-5.00000000000000000000
 Entity.actNormal.vy=1.00000000000000000000
@@ -1231,7 +1239,7 @@ AddEntity
 Entity.h.v=80040019
 Entity.type=5003
 Entity.construction=0
-Entity.point[0].v=80040017
+Entity.point[0].v=80040084
 Entity.actPoint.x=-5.00000000000000000000
 Entity.actPoint.y=5.00000000000000000000
 Entity.actNormal.vx=1.00000000000000000000
@@ -1307,7 +1315,7 @@ AddEntity
 Entity.h.v=80040022
 Entity.type=5003
 Entity.construction=0
-Entity.point[0].v=80040020
+Entity.point[0].v=80040085
 Entity.actPoint.x=10.00000000000000000000
 Entity.actPoint.y=5.00000000000000000000
 Entity.actNormal.vy=-1.00000000000000000000
@@ -1437,7 +1445,7 @@ AddEntity
 Entity.h.v=8004005d
 Entity.type=5003
 Entity.construction=0
-Entity.point[0].v=8004005b
+Entity.point[0].v=80040086
 Entity.actPoint.x=20.00000000000000000000
 Entity.actPoint.z=-5.00000000000000000000
 Entity.actNormal.vx=-1.00000000000000000000
@@ -1511,7 +1519,7 @@ AddEntity
 Entity.h.v=80040066
 Entity.type=5003
 Entity.construction=0
-Entity.point[0].v=80040064
+Entity.point[0].v=80040087
 Entity.actPoint.x=5.00000000000000000000
 Entity.actPoint.z=-5.00000000000000000000
 Entity.actNormal.vy=1.00000000000000000000
@@ -1587,7 +1595,7 @@ AddEntity
 Entity.h.v=8004006f
 Entity.type=5003
 Entity.construction=0
-Entity.point[0].v=8004006d
+Entity.point[0].v=80040088
 Entity.actPoint.x=5.00000000000000000000
 Entity.actPoint.y=10.00000000000000000000
 Entity.actPoint.z=-5.00000000000000000000
@@ -1666,7 +1674,7 @@ AddEntity
 Entity.h.v=80040078
 Entity.type=5003
 Entity.construction=0
-Entity.point[0].v=80040076
+Entity.point[0].v=80040089
 Entity.actPoint.x=20.00000000000000000000
 Entity.actPoint.y=10.00000000000000000000
 Entity.actPoint.z=-5.00000000000000000000