Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conveyor-receiver looking into wrong field name of fts message? #441

Open
maxnoe opened this issue Dec 4, 2024 · 3 comments
Open

conveyor-receiver looking into wrong field name of fts message? #441

maxnoe opened this issue Dec 4, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@maxnoe
Copy link
Contributor

maxnoe commented Dec 4, 2024

Description

Code in receiver.py:

https://github.com/rucio/rucio/blob/3d5cbf5d8c0e37f793bbd6f01d1064e44cfe0b4f/lib/rucio/daemons/conveyor/receiver.py#L80-L82

But dumping the activemq message, the field seems to be called "vo_name", not "vo":

{'archiving': False,
 'archiving_finished': 0,
 'archiving_start': 0,
 'dest_se': 'root://rucio-storage-2',
 'dst_url': 'root://rucio-storage-2:1094//rucio/t_20241204_182207_9bd0/c9/d0//ctao.dpps.test/t_20241204_182207_9bd0/transfer_test/transfer_test.dat',
 'endpnt': 'rucio/fts',
 'file_id': 8872390204,
 'file_metadata': {'activity': 'User Subscriptions',
                   'adler32': 'cbb70c33',
                   'dest_rse_id': 'cac36f36768c49d4abb40b52be10b6d3',
                   'dst_rse': 'STORAGE-2',
                   'dst_type': 'DISK',
                   'filesize': 34,
                   'md5': '5576416e1db3b48361430696dd1bf1a4',
                   'name': '/ctao.dpps.test/t_20241204_182207_9bd0/transfer_test/transfer_test.dat',
                   'request_id': '916da9c602424aa29171c846f60ffe4c',
                   'request_type': 'TRANSFER',
                   'scope': 't_20241204_182207_9bd0',
                   'src_rse': 'STORAGE-1',
                   'src_rse_id': '54d28394bfd340cfa07b788b6983a9e4',
                   'src_type': 'DISK'},
 'file_state': 'FINISHED',
 'job_id': 'ae749618-b26c-11ef-b4f1-0e0d564fbf92',
 'job_metadata': {'auth_method': 'certificate',
                  'issuer': 'rucio',
                  'multi_sources': False,
                  'overwrite_when_only_on_disk': False},
 'job_state': 'FINISHED',
 'reason': '',
 'retry_counter': 0,
 'retry_max': 0,
 'source_se': 'root://rucio-storage-1',
 'src_url': 'root://rucio-storage-1:1094//rucio/t_20241204_182207_9bd0/c9/d0//ctao.dpps.test/t_20241204_182207_9bd0/transfer_test/transfer_test.dat',
 'staging': False,
 'staging_finished': 0,
 'staging_start': 0,
 'submit_time': 1733336532000,
 'timestamp': 1733336536485,
 'user_dn': '',
 'user_filesize': 34,
 'vo_name': '13f3a2a210c3b7cb'}

Steps to reproduce

Current rucio/fts image in kubernetes

Rucio Version

35.4.1, but code in master is the same

Additional Information

No response

@maxnoe maxnoe added the bug Something isn't working label Dec 4, 2024
@maxnoe
Copy link
Contributor Author

maxnoe commented Dec 4, 2024

Looking into fts3 source, it seems inconsistent there:

SendTransferStartMessage and SendTransferFinishMessage use "vo"
https://gitlab.cern.ch/fts/fts3/-/blob/develop/src/monitoring/msg-ifce.cpp?ref_type=heads#L103
https://gitlab.cern.ch/fts/fts3/-/blob/develop/src/monitoring/msg-ifce.cpp?ref_type=heads#L150

but SendTransferStatusChange uses vo_name:
https://gitlab.cern.ch/fts/fts3/-/blob/develop/src/monitoring/msg-ifce.cpp?ref_type=heads#L273

So maybe I am just looking at the wrong messages?

@maxnoe
Copy link
Contributor Author

maxnoe commented Dec 4, 2024

Ok, using the other topic:

/topic/transfer.fts_monitoring_complete

results in this payload, which does have the "vo" field:

{'activity': 'User',
 'auth_method': 'certificate',
 'block_size': 0,
 'buf_size': 0,
 'channel_type': 'urlcopy',
 'chk_timeout': 0,
 'cleanup_code': -1,
 'dest_srm_v': '',
 'dst_hostname': 'rucio-storage-2',
 'dst_se': 'root://rucio-storage-2',
 'dst_site_name': '',
 'dst_url': 'root://rucio-storage-2:1094//rucio/t_20241204_183922_5197/e1/6c//ctao.dpps.test/t_20241204_183922_5197/transfer_test/transfer_test.dat',
 'endpnt': 'rucio/fts',
 'eviction_code': -1,
 'f_size': 34,
 'file_id': 8872390206,
 'file_metadata': {'activity': 'User Subscriptions',
                   'adler32': 'cbb70c33',
                   'dest_rse_id': 'cac36f36768c49d4abb40b52be10b6d3',
                   'dst_rse': 'STORAGE-2',
                   'dst_type': 'DISK',
                   'filesize': 34,
                   'md5': '5576416e1db3b48361430696dd1bf1a4',
                   'name': '/ctao.dpps.test/t_20241204_183922_5197/transfer_test/transfer_test.dat',
                   'request_id': '82f60a5c07c0444bb28a9e365df32239',
                   'request_type': 'TRANSFER',
                   'scope': 't_20241204_183922_5197',
                   'src_rse': 'STORAGE-1',
                   'src_rse_id': '54d28394bfd340cfa07b788b6983a9e4',
                   'src_type': 'DISK'},
 'file_size': 34,
 'final_destination': '',
 'ipver': 'unknown',
 'is_archiving': False,
 'is_recoverable': False,
 'job_id': '1541d1f6-b26f-11ef-9ab5-0e0d564fbf92',
 'job_m_replica': False,
 'job_metadata': {'auth_method': 'certificate',
                  'issuer': 'rucio',
                  'multi_sources': False,
                  'overwrite_when_only_on_disk': False},
 'job_multihop': False,
 'job_state': 'UNKNOWN',
 'nstreams': 1,
 'operation_time': 3155,
 'overwrite_on_disk_deletion_code': -1,
 'overwrite_on_disk_flag': False,
 'protocol': 'root',
 'retry': 0,
 'retry_max': 0,
 'scitag': 0,
 'src_hostname': 'rucio-storage-1',
 'src_se': 'root://rucio-storage-1',
 'src_site_name': '',
 'src_srm_v': '',
 'src_url': 'root://rucio-storage-1:1094//rucio/t_20241204_183922_5197/e1/6c//ctao.dpps.test/t_20241204_183922_5197/transfer_test/transfer_test.dat',
 'srm_finalization_time': 0,
 'srm_overhead_percentage': 0.0,
 'srm_overhead_time': 0,
 'srm_preparation_time': 0,
 'srm_space_token_dst': '',
 'srm_space_token_src': '',
 't__error_message': '',
 't_channel': 'rucio-storage-1__rucio-storage-2',
 't_error_code': 0,
 't_failure_phase': '',
 't_final_transfer_state': 'Ok',
 't_final_transfer_state_flag': 1,
 't_timeout': 601,
 'tcp_buf_size': 0,
 'throughput': 11.954992967651195,
 'time_srm_fin_end': 0,
 'time_srm_fin_st': 0,
 'time_srm_prep_end': 0,
 'time_srm_prep_st': 0,
 'timestamp_checksum_dest_ended': 0,
 'timestamp_checksum_dest_st': 0,
 'timestamp_checksum_dst_diff': 0,
 'timestamp_checksum_src_diff': 0,
 'timestamp_chk_src_ended': 0,
 'timestamp_chk_src_st': 0,
 'timestamp_tr_comp': 1733337568877,
 'timestamp_tr_st': 1733337566033,
 'tr_bt_transfered': 34,
 'tr_error_category': '',
 'tr_error_scope': '',
 'tr_id': '2024-12-04-1839__rucio-storage-1__rucio-storage-2__8872390206__1541d1f6-b26f-11ef-9ab5-0e0d564fbf92',
 'tr_timestamp_complete': 1733337569024,
 'tr_timestamp_start': 1733337565869,
 'transfer_lasthop': False,
 'transfer_time': 2844,
 'transfer_type': '3rd pull',
 'user_dn': '',
 'vo': '13f3a2a210c3b7cb'}

@maxnoe
Copy link
Contributor Author

maxnoe commented Dec 5, 2024

I guess this could be closed or converted into a documentation issue.

@bari12 bari12 transferred this issue from rucio/rucio Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant