Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Source Usage in Documentation Generation Process #414

Open
Geogouz opened this issue Dec 6, 2024 · 1 comment
Open

Inconsistent Source Usage in Documentation Generation Process #414

Geogouz opened this issue Dec 6, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Geogouz
Copy link
Contributor

Geogouz commented Dec 6, 2024

I think that the documentation generation process in tools/build_documentation.sh inconsistently sources Rucio components from different locations.

Bin Help Documentation and REST API Documentation:

  • Uses the locally cloned repository from /run_in_docker/rucio/ and generates documentation from the current codebase

Client API Documentation

  • Uses the system-installed Rucio from /opt/venv/lib/python3.9/site-packages/rucio/, ignoring the locally cloned repository at /run_in_docker/rucio/

  • In my case (as I wanted to consider/apply my client's modifications inside /run_in_docker/rucio/lib) I bypassed this by adding /run_in_docker/rucio/lib to PYTHONPATH (in the generate_docs.shright before the called generate_client_api_docs.sh).

-Is this behavior intentional?
-What's the intended workflow for testing client's documentation changes?

@voetberg
Copy link
Contributor

voetberg commented Dec 9, 2024

a) That's certainly not intentional behavior to my knowledge.

b) The only thing testing the documentation changes is verifying the build works not checking the contents of them. I'm not sure of any method to verify changes went through though. If you have suggestions I'm all ears.

@voetberg voetberg added the enhancement New feature or request label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants