Add linter to CI

Also, pass all linters

Author: lloeki

.github/workflows/build.yml

@@ -3,6 +3,28 @@ on:
     - push
 
 jobs:
+  rubocop:
+    name: Lint (Rubocop)
+    runs-on: ubuntu-20.04
+    container: ruby:2.3
+    steps:
+     - name: Checkout
+       uses: actions/checkout@v2
+     - name: Bundle
+       run: bundle install
+     - name: Rubocop
+       run: bundle exec rubocop -f simple
+  shellcheck:
+    name: Lint (Shellcheck)
+    runs-on: ubuntu-20.04
+    container: debian:10
+    steps:
+     - name: Checkout
+       uses: actions/checkout@v2
+     - name: Install shellcheck
+       run: apt-get update && apt-get install -y shellcheck
+     - name: Shellcheck
+       run: shellcheck libexec/*
   build-ruby:
     name: Build (ruby)
     runs-on: ubuntu-20.04

.rubocop.yml

@@ -1,7 +1,13 @@
 AllCops:
   TargetRubyVersion: 2.0
   Exclude:
-    - src/**
+    - src/**/*
+    - pkg/**/*
+    - vendor/**/*
+
+Naming/FileName:
+  Exclude:
+    - lib/libv8-node.rb
 
 Style/Documentation:
   Enabled: false
@@ -14,3 +20,9 @@ Style/NumericPredicate:
 
 Metrics/LineLength:
   Enabled: false
+
+Style/WordArray:
+  Enabled: false
+
+Style/PerlBackrefs:
+  Enabled: false

Rakefile

@@ -58,9 +58,14 @@ namespace :binary do
     Helpers.binary_gemspec # loads NODE_VERSION
     major, minor = File.read(Dir["src/node-#{Libv8::Node::NODE_VERSION}/common.gypi"].last).lines.find { |l| l =~ /-mmacosx-version-min=(\d+).(\d+)/ } && [Integer($1), Integer($2)]
 
-    first = minor + 4 # macos 10.X => darwinY offset
-    first = 20 if RUBY_PLATFORM =~ /^arm46/
-    max = 20 # current known max
+    first = if RUBY_PLATFORM =~ /\barm64e?-/
+              20 # arm64 darwin is only available since darwin20
+            elsif major == '10'
+              minor + 4 # macos 10.X => darwinY offset, 10.15 is darwin19
+            else
+              minor + 20 # maxos 11.X => darwinY offset, 11.0 is darwin20
+            end
+    max = 20 # current known max to build for
 
     (first..max).each do |version|
       next if version == current

ext/libv8-node/builder.rb

@@ -41,7 +41,10 @@ def inject_libv8(version)
     end
 
     def script(name)
-      File.expand_path("../../libexec/#{name}", __dir__).tap { |v| p Dir.pwd; p v }
+      File.expand_path("../../libexec/#{name}", __dir__).tap do |v|
+        puts "==== in #{Dir.pwd}"
+        puts "==== running #{v}"
+      end
     end
   end
 end

libexec/build-libv8

@@ -17,7 +17,7 @@ echo "parallel job count: ${NJOBS}"
 
 cd "${src}/node-${version}"
 
-if which python3 >/dev/null 2>&1; then
+if command -v python3 >/dev/null 2>&1; then
     PYTHON="${PYTHON:-python3}"
 else
     PYTHON="${PYTHON:-python2}"

libexec/download-node

@@ -21,4 +21,5 @@ esac
 
 mkdir -p "${src}"
 
+# shellcheck disable=SC2086
 curl ${CURLOPTS} -L -o "${src}/node-${version}.tar.gz" "https://github.com/nodejs/node/archive/v${version}.tar.gz"

libexec/inject-libv8

@@ -36,6 +36,7 @@ done
 cd "${BASEDIR}/out/${BUILDTYPE}"
 
 rm -rf "${top}/vendor/v8/out.gn"
+# shellcheck disable=SC2043
 for lib in libv8_monolith.a; do
     dir="${top}/vendor/v8/out.gn/libv8/obj/$(dirname "${lib}")"
     mkdir -p "${dir}"