Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5021 - Fixed break of list items on validation of new barcode item #5045

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Naraveni
Copy link
Contributor

Resolves #5021

Description

List Items was breaking on validation of new barcode item

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I wrote test cases to make sure thar item list is available on validation.

@Naraveni Naraveni force-pushed the 5021-FIX-NEW-BARCODE-LIST-ON-VALIDATE branch from 45e9581 to 17027d7 Compare February 27, 2025 18:05
@Naraveni Naraveni force-pushed the 5021-FIX-NEW-BARCODE-LIST-ON-VALIDATE branch from b984d0f to 79c9829 Compare February 27, 2025 18:32
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This works - @dorner do you have any technical comments?

@cielf cielf requested a review from dorner February 28, 2025 19:50
Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please replace the controller spec with a request spec? That's the recommended approach for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Validation on new barcode item breaks the list of items
3 participants