Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total on Hand is Unknown for inactive Items on Itemized Reports -- should be 0. #5004

Open
2 tasks
cielf opened this issue Feb 9, 2025 · 0 comments
Open
2 tasks
Labels

Comments

@cielf
Copy link
Collaborator

cielf commented Feb 9, 2025

Summary

In itemized reports, the total on hand for inactive items should be 0, rather than "Unknown"

Why

We only allow items to be deactivated if the total on hand is 0, so we do know.

Details

To see this,
sign in as [email protected],

Reduce the quantities in inventory on Adult Briefs (Medium/Large) to 0 (I usually use a couple of distributions to do this.), then go in to Inventory | Items & Inventory and deactivate the item

click reports, then 'Itemized Donations'.

You'll see that the Total On Hand for Adult Briefs (Medium/Large) is Unknown. We know that it is 0. (screenshot is from a different example, but you get the idea)

Image

This is left from when we allowed deactivation of items without first 0ing the inventory.

The Total On Hand should be 0 for any inactive item.

Confirm and fix this behaviour on Donations - Itemized, Distributions - Itemized, and Purchases - Itemized.

Criteria for Completion

  • Total On Hand shows 0 for any inactive item
  • Tests to confirm
@cielf cielf added Difficulty—Beginner Help Wanted Groomed + open to all! labels Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant