Update to tailwind 4 #227
Closed
Update to tailwind 4 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephannv
approved these changes
Mar 7, 2025
Comment on lines
+5
to
+10
| @source "./app/views/**/*.rb"; /* Phlex views */ | ||
| @source "./app/components/**/*.rb"; /* Phlex components */ | ||
| @source "./app/views/**/*.html.erb"; | ||
| @source "./app/helpers/**/*.rb"; | ||
| @source "./app/assets/stylesheets/**/*.css"; | ||
| @source "./app/javascript/**/*.js"; |
There was a problem hiding this comment.
I think we don't need this anymore, because Tailwind 4 looks for tailwind classes in all project files.
| --border: 240 3.7% 15.9%; | ||
| --input: 240 3.7% 15.9%; | ||
| --ring: 240 4.9% 83.9%; | ||
| :root { |
There was a problem hiding this comment.
About these variables, I think we can copy from Shadcn, what do you think?
https://ui.shadcn.com/docs/installation/manual (Step 4 Configure styles)
|
@sethhorsley I added you as co-author in this PR: #237 I'm closing this PR, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is to track the update to tailwind 4