Replies: 2 comments
-
@budu Why is rubocop is asking to add super? In this case I don't think it makes sense because it isn't a requirement from Phlex::HTML. We are using standard-rb and it's fine to use without adding |
Beta Was this translation helpful? Give feedback.
-
This cop is just a general good practice kind of thing, you can see the original issue: rubocop/ruby-style-guide#809. In summary, always calling super can prevent some subtle bugs down the line. The idea here would be that I'm perfectly okay with not calling super, this is not an real issue. |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Hi, the first thing I do after installing RubyUI is to add a call to
super()
in the base class initialize method. Mostly to fix rubocop complaining about it, but I think it's a valid point.Would it be a good idea to add this to the base class copied by the generator?
Beta Was this translation helpful? Give feedback.
All reactions