improves method readability

karinevieira · karinevieira · commit 3eae4a145481 · 2025-02-07T13:45:46.000-03:00
diff --git a/lib/ruby_ui/combobox/combobox_controller.js b/lib/ruby_ui/combobox/combobox_controller.js
@@ -35,8 +35,9 @@ export default class extends Controller {
       this.closePopover()
     }
 
-    const isToggleAllUnchecked = this.hasToggleAllTarget && !e.target.checked
-    if (isToggleAllUnchecked) this.toggleAllTarget.checked = false
+    if (this.hasToggleAllTarget && !e.target.checked) {
+      this.toggleAllTarget.checked = false
+    }
   }
 
   inputContent(input) {

Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,9 @@ export default class extends Controller {`
`35`	`35`	`this.closePopover()`
`36`	`36`	`}`
`37`	`37`
`38`		`- const isToggleAllUnchecked = this.hasToggleAllTarget && !e.target.checked`
`39`		`- if (isToggleAllUnchecked) this.toggleAllTarget.checked = false`
	`38`	`+ if (this.hasToggleAllTarget && !e.target.checked) {`
	`39`	`+ this.toggleAllTarget.checked = false`
	`40`	`+ }`
`40`	`41`	`}`
`41`	`42`
`42`	`43`	`inputContent(input) {`