Skip to content

Commit a6c4ae9

Browse files
arichivChromium LUCI CQ
authored and
Chromium LUCI CQ
committed
headless: Merge "headless_renderer" target into "headless_shared_sources"
Derived from tkent's work in https://chromium-review.googlesource.com/c/chromium/src/+/3865941 In order to fix "gn check" errors, this CL moves all dependencies of headless_content_main_delegate.* to "headless_shared_sources". As the result, all sources in "headless_(non_)renderer" are moved to "headless_shared_sources". Bug: 1158989 Change-Id: I5701a8becada158e8443def7a434b5fd57830491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4125896 Auto-Submit: Ari Chivukula <[email protected]> Reviewed-by: Bruce Dawson <[email protected]> Reviewed-by: Sami Kyöstilä <[email protected]> Commit-Queue: Ari Chivukula <[email protected]> Cr-Commit-Position: refs/heads/main@{#1087705}
1 parent ca57bfa commit a6c4ae9

File tree

3 files changed

+107
-213
lines changed

3 files changed

+107
-213
lines changed

.gn

-4
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,6 @@ default_args = {
6868
# their includes checked for proper dependencies when you run either
6969
# "gn check" or "gn gen --check".
7070
no_check_targets = [
71-
# crbug.com/1158989
72-
"//headless:headless_renderer", # 12 errors
73-
"//headless:headless_shared_sources", # 2 errors
74-
7571
# //v8, https://crbug.com/v8/7330
7672
"//v8/src/inspector:inspector", # 20 errors
7773
"//v8/test/cctest:cctest_sources", # 15 errors

chrome/BUILD.gn

+1-1
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ if (is_win) {
411411
"//components/policy:generated",
412412
"//content/public/app",
413413
"//crypto",
414-
"//headless:headless_renderer",
414+
"//headless:headless_non_renderer",
415415
"//headless:headless_shell_browser_lib",
416416
"//net:net_resources",
417417
"//ppapi/buildflags",

0 commit comments

Comments
 (0)