Skip to content

Commit 4de6dab

Browse files
Avi DrissmanChromium LUCI CQ
Avi Drissman
authored and
Chromium LUCI CQ
committed
Update header includes for /base/functional in /apps and /ash
bind.h, callback.h, callback_forward.h, and callback_helpers.h moved into /base/functional/. Update the include paths to directly include them in their new location. Bug: 1364441 Change-Id: I7fbd0e591b4703f62e7f4cc98caec615a38bc1bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4144718 Auto-Submit: Avi Drissman <[email protected]> Owners-Override: Daniel Cheng <[email protected]> Owners-Override: Avi Drissman <[email protected]> Commit-Queue: Daniel Cheng <[email protected]> Reviewed-by: Daniel Cheng <[email protected]> Cr-Commit-Position: refs/heads/main@{#1089944}
1 parent f2bdb12 commit 4de6dab

File tree

958 files changed

+1109
-1114
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

958 files changed

+1109
-1114
lines changed

apps/launcher.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88
#include <set>
99
#include <utility>
1010

11-
#include "base/bind.h"
1211
#include "base/command_line.h"
1312
#include "base/files/file_path.h"
1413
#include "base/files/file_util.h"
14+
#include "base/functional/bind.h"
1515
#include "base/logging.h"
1616
#include "base/memory/raw_ptr.h"
1717
#include "base/memory/ref_counted.h"

ash/accelerators/key_hold_detector.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include <utility>
99

1010
#include "ash/shell.h"
11-
#include "base/bind.h"
11+
#include "base/functional/bind.h"
1212
#include "base/task/single_thread_task_runner.h"
1313
#include "ui/aura/window_tracker.h"
1414
#include "ui/aura/window_tree_host.h"

ash/accelerometer/accelerometer_file_reader.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
#include "ash/public/cpp/tablet_mode_observer.h"
1515
#include "ash/shell.h"
1616
#include "ash/wm/tablet_mode/tablet_mode_controller.h"
17-
#include "base/bind.h"
1817
#include "base/files/file_enumerator.h"
1918
#include "base/files/file_util.h"
19+
#include "base/functional/bind.h"
2020
#include "base/location.h"
2121
#include "base/memory/singleton.h"
2222
#include "base/numerics/math_constants.h"

ash/accelerometer/accelerometer_provider_mojo.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#include "ash/accelerometer/accelerometer_constants.h"
1111
#include "ash/shell.h"
1212
#include "ash/wm/tablet_mode/tablet_mode_controller.h"
13-
#include "base/bind.h"
13+
#include "base/functional/bind.h"
1414
#include "base/ranges/algorithm.h"
1515
#include "base/strings/string_number_conversions.h"
1616
#include "base/strings/string_util.h"

ash/accelerometer/accelerometer_samples_observer.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
#include <utility>
88

9-
#include "base/bind.h"
9+
#include "base/functional/bind.h"
1010

1111
namespace ash {
1212

ash/accelerometer/accelerometer_samples_observer_unittest.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include <utility>
99

1010
#include "ash/accelerometer/accelerometer_constants.h"
11-
#include "base/bind.h"
11+
#include "base/functional/bind.h"
1212
#include "base/run_loop.h"
1313
#include "base/test/task_environment.h"
1414
#include "chromeos/components/sensors/fake_sensor_device.h"

ash/accessibility/accessibility_controller_impl.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@
4949
#include "ash/system/power/power_status.h"
5050
#include "ash/system/power/scoped_backlights_forced_off.h"
5151
#include "ash/wm/tablet_mode/tablet_mode_controller.h"
52-
#include "base/bind.h"
53-
#include "base/callback_helpers.h"
52+
#include "base/functional/bind.h"
53+
#include "base/functional/callback_helpers.h"
5454
#include "base/metrics/histogram_functions.h"
5555
#include "base/metrics/histogram_macros.h"
5656
#include "base/metrics/user_metrics.h"

ash/accessibility/accessibility_controller_impl.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
#include "ash/public/cpp/accessibility_controller.h"
1414
#include "ash/public/cpp/session/session_observer.h"
1515
#include "ash/public/cpp/tablet_mode_observer.h"
16-
#include "base/callback_forward.h"
16+
#include "base/functional/callback_forward.h"
1717
#include "base/memory/weak_ptr.h"
1818
#include "base/observer_list.h"
1919
#include "base/time/time.h"

ash/accessibility/accessibility_controller_unittest.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "ash/session/test_pref_service_provider.h"
2121
#include "ash/shell.h"
2222
#include "ash/test/ash_test_base.h"
23-
#include "base/bind.h"
23+
#include "base/functional/bind.h"
2424
#include "base/strings/utf_string_conversions.h"
2525
#include "base/test/scoped_feature_list.h"
2626
#include "chromeos/dbus/power/fake_power_manager_client.h"

ash/accessibility/autoclick/autoclick_controller.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
#include "ash/system/accessibility/autoclick_menu_bubble_controller.h"
2020
#include "ash/wm/fullscreen_window_finder.h"
2121
#include "ash/wm/window_util.h"
22-
#include "base/bind.h"
22+
#include "base/functional/bind.h"
2323
#include "base/metrics/histogram_macros.h"
2424
#include "base/metrics/user_metrics.h"
2525
#include "base/timer/timer.h"

ash/accessibility/chromevox/touch_exploration_controller.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
#include "ash/shell.h"
1515
#include "ash/wm/container_finder.h"
1616
#include "ash/wm/tablet_mode/tablet_mode_controller.h"
17-
#include "base/bind.h"
17+
#include "base/functional/bind.h"
1818
#include "base/logging.h"
1919
#include "base/ranges/algorithm.h"
2020
#include "base/strings/string_number_conversions.h"

ash/accessibility/magnifier/docked_magnifier_controller.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@
2020
#include "ash/wm/overview/overview_controller.h"
2121
#include "ash/wm/splitview/split_view_controller.h"
2222
#include "ash/wm/work_area_insets.h"
23-
#include "base/bind.h"
2423
#include "base/cxx17_backports.h"
24+
#include "base/functional/bind.h"
2525
#include "components/prefs/pref_change_registrar.h"
2626
#include "components/prefs/pref_registry_simple.h"
2727
#include "components/prefs/pref_service.h"

ash/accessibility/sticky_keys/sticky_keys_unittest.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66

77
#include "ash/shell.h"
88
#include "ash/test/ash_test_base.h"
9-
#include "base/bind.h"
10-
#include "base/callback.h"
9+
#include "base/functional/bind.h"
10+
#include "base/functional/callback.h"
1111
#include "ui/aura/window.h"
1212
#include "ui/aura/window_tree_host.h"
1313
#include "ui/events/event_source.h"

ash/accessibility/switch_access/point_scan_controller_unittest.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
#include "ash/shell.h"
88
#include "ash/test/ash_test_base.h"
99
#include "ash/test/test_window_builder.h"
10-
#include "base/bind.h"
1110
#include "base/command_line.h"
11+
#include "base/functional/bind.h"
1212
#include "base/test/scoped_feature_list.h"
1313
#include "third_party/skia/include/core/SkBitmap.h"
1414
#include "ui/aura/window.h"

ash/accessibility/ui/accessibility_animation_one_shot.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
#ifndef ASH_ACCESSIBILITY_UI_ACCESSIBILITY_ANIMATION_ONE_SHOT_H_
66
#define ASH_ACCESSIBILITY_UI_ACCESSIBILITY_ANIMATION_ONE_SHOT_H_
77

8-
#include "base/callback.h"
8+
#include "base/functional/callback.h"
99
#include "base/scoped_observation.h"
1010
#include "base/time/time.h"
1111
#include "ui/compositor/compositor_animation_observer.h"

ash/accessibility/ui/accessibility_confirmation_dialog.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#include "ash/session/session_controller_impl.h"
1212
#include "ash/shell.h"
1313
#include "ash/strings/grit/ash_strings.h"
14-
#include "base/bind.h"
14+
#include "base/functional/bind.h"
1515
#include "ui/base/l10n/l10n_util.h"
1616
#include "ui/base/ui_base_types.h"
1717
#include "ui/views/border.h"

ash/accessibility/ui/accessibility_confirmation_dialog.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
#include <string>
99

10-
#include "base/callback_forward.h"
10+
#include "base/functional/callback_forward.h"
1111
#include "base/memory/weak_ptr.h"
1212
#include "ui/views/window/dialog_delegate.h"
1313

ash/accessibility/ui/accessibility_focus_ring_controller_impl.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
#include "ash/accessibility/ui/layer_animation_info.h"
1717
#include "ash/ash_export.h"
1818
#include "ash/public/cpp/accessibility_focus_ring_controller.h"
19-
#include "base/bind.h"
19+
#include "base/functional/bind.h"
2020
#include "base/time/time.h"
2121
#include "third_party/skia/include/core/SkColor.h"
2222
#include "ui/gfx/geometry/rect.h"

ash/accessibility/ui/accessibility_focus_ring_layer.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
#include "ash/public/cpp/shell_window_ids.h"
88
#include "ash/shell.h"
9-
#include "base/bind.h"
9+
#include "base/functional/bind.h"
1010
#include "third_party/skia/include/core/SkPaint.h"
1111
#include "third_party/skia/include/core/SkPath.h"
1212
#include "third_party/skia/include/effects/SkDashPathEffect.h"

ash/accessibility/ui/accessibility_highlight_controller_unittest.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@
1616
#include "ash/shell.h"
1717
#include "ash/test/ash_test_base.h"
1818
#include "ash/test/test_window_builder.h"
19-
#include "base/bind.h"
2019
#include "base/command_line.h"
20+
#include "base/functional/bind.h"
2121
#include "third_party/skia/include/core/SkBitmap.h"
2222
#include "ui/aura/window.h"
2323
#include "ui/base/ime/dummy_text_input_client.h"

ash/ambient/ambient_access_token_controller.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
#include "ash/login/ui/lock_screen.h"
88
#include "ash/public/cpp/ambient/ambient_client.h"
9-
#include "base/bind.h"
9+
#include "base/functional/bind.h"
1010
#include "base/logging.h"
1111
#include "base/rand_util.h"
1212
#include "base/time/time.h"

ash/ambient/ambient_controller.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,10 @@
3939
#include "ash/shell.h"
4040
#include "ash/strings/grit/ash_strings.h"
4141
#include "ash/system/power/power_status.h"
42-
#include "base/bind.h"
43-
#include "base/callback_helpers.h"
4442
#include "base/check.h"
4543
#include "base/feature_list.h"
44+
#include "base/functional/bind.h"
45+
#include "base/functional/callback_helpers.h"
4646
#include "base/memory/weak_ptr.h"
4747
#include "base/time/time.h"
4848
#include "base/timer/timer.h"

ash/ambient/ambient_controller_unittest.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
#include "ash/shell.h"
2525
#include "ash/system/power/power_status.h"
2626
#include "ash/wm/tablet_mode/tablet_mode_controller.h"
27-
#include "base/callback.h"
27+
#include "base/functional/callback.h"
2828
#include "base/location.h"
2929
#include "base/ranges/algorithm.h"
3030
#include "base/run_loop.h"

ash/ambient/ambient_photo_cache.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
#include "ash/constants/ash_features.h"
1313
#include "ash/public/cpp/ambient/ambient_client.h"
1414
#include "ash/public/cpp/ambient/proto/photo_cache_entry.pb.h"
15-
#include "base/bind.h"
1615
#include "base/files/file_util.h"
16+
#include "base/functional/bind.h"
1717
#include "base/memory/weak_ptr.h"
1818
#include "base/path_service.h"
1919
#include "base/strings/string_number_conversions.h"

ash/ambient/ambient_photo_cache.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010

1111
#include "ash/ash_export.h"
1212
#include "ash/public/cpp/ambient/proto/photo_cache_entry.pb.h"
13-
#include "base/callback_forward.h"
1413
#include "base/files/file_path.h"
14+
#include "base/functional/callback_forward.h"
1515

1616
namespace gfx {
1717
class ImageSkia;

ash/ambient/ambient_photo_cache_unittest.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@
1313
#include "ash/ambient/test/test_ambient_client.h"
1414
#include "ash/constants/ash_features.h"
1515
#include "ash/public/cpp/ambient/proto/photo_cache_entry.pb.h"
16-
#include "base/bind.h"
1716
#include "base/files/file_path.h"
1817
#include "base/files/file_util.h"
18+
#include "base/functional/bind.h"
1919
#include "base/path_service.h"
2020
#include "base/run_loop.h"
2121
#include "base/test/bind.h"

ash/ambient/ambient_photo_controller.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,10 +23,10 @@
2323
#include "base/barrier_closure.h"
2424
#include "base/base64.h"
2525
#include "base/base_paths.h"
26-
#include "base/bind.h"
27-
#include "base/callback.h"
2826
#include "base/files/file_path.h"
2927
#include "base/files/file_util.h"
28+
#include "base/functional/bind.h"
29+
#include "base/functional/callback.h"
3030
#include "base/guid.h"
3131
#include "base/hash/sha1.h"
3232
#include "base/path_service.h"

ash/ambient/ambient_photo_controller.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
#include "ash/ash_export.h"
2020
#include "ash/public/cpp/ambient/ambient_backend_controller.h"
2121
#include "ash/public/cpp/ambient/proto/photo_cache_entry.pb.h"
22-
#include "base/callback_forward.h"
22+
#include "base/functional/callback_forward.h"
2323
#include "base/memory/scoped_refptr.h"
2424
#include "base/memory/weak_ptr.h"
2525
#include "base/scoped_observation.h"

ash/ambient/ambient_photo_controller_unittest.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,13 @@
2626
#include "ash/shell.h"
2727
#include "base/barrier_closure.h"
2828
#include "base/base_paths.h"
29-
#include "base/bind.h"
30-
#include "base/callback.h"
3129
#include "base/check.h"
3230
#include "base/containers/contains.h"
3331
#include "base/files/file_enumerator.h"
3432
#include "base/files/file_path.h"
3533
#include "base/files/file_util.h"
34+
#include "base/functional/bind.h"
35+
#include "base/functional/callback.h"
3636
#include "base/hash/sha1.h"
3737
#include "base/path_service.h"
3838
#include "base/run_loop.h"

ash/ambient/ambient_view_delegate_impl.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66

77
#include "ash/ambient/ambient_controller.h"
88
#include "ash/ambient/model/ambient_backend_model.h"
9-
#include "base/bind.h"
109
#include "base/check.h"
10+
#include "base/functional/bind.h"
1111
#include "base/threading/sequenced_task_runner_handle.h"
1212

1313
namespace ash {

ash/ambient/ambient_weather_controller.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@
1212
#include "ash/public/cpp/ambient/ambient_backend_controller.h"
1313
#include "ash/public/cpp/image_downloader.h"
1414
#include "ash/shell.h"
15-
#include "base/bind.h"
16-
#include "base/callback.h"
1715
#include "base/check.h"
16+
#include "base/functional/bind.h"
17+
#include "base/functional/callback.h"
1818
#include "net/traffic_annotation/network_traffic_annotation.h"
1919
#include "third_party/abseil-cpp/absl/types/optional.h"
2020

ash/ambient/autotest_ambient_api.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99
#include "ash/ambient/ui/ambient_view_delegate.h"
1010
#include "ash/public/cpp/ambient/ambient_backend_controller.h"
1111
#include "ash/shell.h"
12-
#include "base/bind.h"
13-
#include "base/callback.h"
12+
#include "base/functional/bind.h"
13+
#include "base/functional/callback.h"
1414
#include "base/time/time.h"
1515
#include "base/timer/timer.h"
1616

ash/ambient/autotest_ambient_api_unittest.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
#include "ash/public/cpp/ambient/ambient_prefs.h"
1010
#include "ash/session/session_controller_impl.h"
1111
#include "ash/shell.h"
12-
#include "base/bind.h"
12+
#include "base/functional/bind.h"
1313
#include "base/notreached.h"
1414
#include "base/run_loop.h"
1515
#include "components/prefs/pref_service.h"

ash/ambient/backdrop/ambient_backend_controller_impl.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
#include "ash/wallpaper/wallpaper_utils/wallpaper_language.h"
2424
#include "base/barrier_closure.h"
2525
#include "base/base64.h"
26-
#include "base/bind.h"
26+
#include "base/functional/bind.h"
2727
#include "base/guid.h"
2828
#include "base/logging.h"
2929
#include "base/time/time.h"

ash/ambient/model/ambient_animation_photo_provider.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,9 @@
6666
#include "ash/public/cpp/ambient/ambient_metrics.h"
6767
#include "ash/utility/cropping_util.h"
6868
#include "ash/utility/lottie_util.h"
69-
#include "base/bind.h"
70-
#include "base/callback.h"
7169
#include "base/check.h"
70+
#include "base/functional/bind.h"
71+
#include "base/functional/callback.h"
7272
#include "base/logging.h"
7373
#include "base/memory/scoped_refptr.h"
7474
#include "base/notreached.h"

ash/ambient/model/ambient_topic_queue.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
#include "ash/public/cpp/shell_window_ids.h"
1616
#include "ash/shell.h"
1717
#include "base/barrier_closure.h"
18-
#include "base/bind.h"
1918
#include "base/check.h"
2019
#include "base/containers/flat_map.h"
20+
#include "base/functional/bind.h"
2121
#include "base/location.h"
2222
#include "base/task/sequenced_task_runner.h"
2323
#include "ui/display/display.h"

ash/ambient/model/ambient_topic_queue.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212

1313
#include "ash/ash_export.h"
1414
#include "ash/public/cpp/ambient/ambient_backend_controller.h"
15-
#include "base/callback.h"
1615
#include "base/containers/flat_map.h"
16+
#include "base/functional/callback.h"
1717
#include "base/memory/raw_ptr.h"
1818
#include "base/memory/weak_ptr.h"
1919
#include "base/time/time.h"

ash/ambient/test/ambient_ash_test_base.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@
2929
#include "ash/root_window_controller.h"
3030
#include "ash/session/session_controller_impl.h"
3131
#include "ash/shell.h"
32-
#include "base/bind.h"
33-
#include "base/callback.h"
32+
#include "base/functional/bind.h"
33+
#include "base/functional/callback.h"
3434
#include "base/location.h"
3535
#include "base/memory/ptr_util.h"
3636
#include "base/run_loop.h"

ash/ambient/test/ambient_ash_test_base.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#include "ash/public/cpp/ambient/proto/photo_cache_entry.pb.h"
2121
#include "ash/public/cpp/test/test_image_downloader.h"
2222
#include "ash/test/ash_test_base.h"
23-
#include "base/callback.h"
23+
#include "base/functional/callback.h"
2424
#include "base/time/time.h"
2525
#include "services/media_session/public/mojom/media_session.mojom.h"
2626
#include "ui/views/view.h"

0 commit comments

Comments
 (0)