fix: vary responses used in tests as http status will not always be :ok

Author: nzlaura

spec/rubocop/cop/rspec_rails/minitest_assertions_spec.rb

@@ -951,48 +951,59 @@
   context 'with response assertions' do
     it 'registers an offense when using `assert_response`' do
       expect_offense(<<~RUBY)
-        assert_response :ok
-        ^^^^^^^^^^^^^^^^^^^ Use `expect(response).to have_http_status(:ok)`.
+        assert_response :redirect
+        ^^^^^^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to have_http_status(:redirect)`.
       RUBY
 
       expect_correction(<<~RUBY)
-        expect(response).to have_http_status(:ok)
+        expect(response).to have_http_status(:redirect)
+      RUBY
+    end
+
+    it 'registers an offense when using `assert_response` with a number' do
+      expect_offense(<<~RUBY)
+        assert_response 302
+        ^^^^^^^^^^^^^^^^^^^ Use `expect(response).to have_http_status(302)`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        expect(response).to have_http_status(302)
       RUBY
     end
 
     it 'registers an offense when using `assert_response` with parentheses' do
       expect_offense(<<~RUBY)
-        assert_response(:ok)
-        ^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to have_http_status(:ok)`.
+        assert_response(:success)
+        ^^^^^^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to have_http_status(:success)`.
       RUBY
 
       expect_correction(<<~RUBY)
-        expect(response).to have_http_status(:ok)
+        expect(response).to have_http_status(:success)
       RUBY
     end
 
     it 'registers an offense when using `assert_response` with ' \
        'failure message' do
       expect_offense(<<~RUBY)
-        assert_response :ok, "expected OK status"
-        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to(have_http_status(:ok), "expected OK status")`.
+        assert_response :success, "expected success status"
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to(have_http_status(:success), "expected success status")`.
       RUBY
 
       expect_correction(<<~RUBY)
-        expect(response).to(have_http_status(:ok), "expected OK status")
+        expect(response).to(have_http_status(:success), "expected success status")
       RUBY
     end
 
     it 'registers an offense when using `assert_response` with ' \
        'multi-line arguments' do
       expect_offense(<<~RUBY)
-        assert_response(:ok,
-        ^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to(have_http_status(:ok), "expected OK status")`.
-                        "expected OK status")
+        assert_response(:redirect,
+        ^^^^^^^^^^^^^^^^^^^^^^^^^^ Use `expect(response).to(have_http_status(:redirect), "expected redirect status")`.
+                        "expected redirect status")
       RUBY
 
       expect_correction(<<~RUBY)
-        expect(response).to(have_http_status(:ok), "expected OK status")
+        expect(response).to(have_http_status(:redirect), "expected redirect status")
       RUBY
     end
 
@@ -1011,7 +1022,7 @@
     it 'does not register an offense when using ' \
        '`expect(response).to have_http_status`' do
       expect_no_offenses(<<~RUBY)
-        expect(response).to have_http_status(:ok)
+        expect(response).to have_http_status(:success)
       RUBY
     end