Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of extraction strategies #65

Closed
gabegorelick opened this issue Dec 8, 2014 · 3 comments
Closed

Get rid of extraction strategies #65

gabegorelick opened this issue Dec 8, 2014 · 3 comments

Comments

@gabegorelick
Copy link
Collaborator

angular-gettext shouldn't be in the business of trying to guess whether to use the JS or HTML extractor on a given file. As it stands, we get feature requests to add support for HTML-like languages all the time. We can leave the existing strategies in place, but the docs should be updated to have people just call extractHtml or extractJs directly.

@gabegorelick
Copy link
Collaborator Author

#68 is a step in the right direction.

@rubenv
Copy link
Owner

rubenv commented Dec 9, 2014

I sort of disagree. People shouldn't be bothered with this choice: it should do the right thing automatically if you work according to common sense.

One of the design philosophies I have in mind for angular-gettext is that it's opinionated: we only ask the truly crucial questions. Anything that's optional or unneeded probably shouldn't be there. This leads to a nice property: there's only 1 way of doing things, which should be very easy. If things are hard, you'll probably be deviating from how things should work, which should be a signal that you might want to reconsider things.

If you're the kind of person who likes to do strange things, well... you deserve your world of pain.

@gabegorelick
Copy link
Collaborator Author

File classification just seems so orthogonal to gettext extraction and compilation to me. But it's your call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants