fix(gradle): address PR review — state machine bugs, snapshot tests, 60% threshold

- Fix `* Try:` block leak: skip all lines starting with `>` or `* ` inside block
- Fix `in_failed_test` dead reset: remove unreachable empty-line check, reset on
  `> Task`, `BUILD`, or test summary lines instead
- Fix dep tree duplicate BUILD line: check BUILD before pushing as tree node
- Raise dependency tree savings threshold from 40% to 60% (project minimum)
- Add 6 insta snapshot tests for all filter scenarios
- Add `insta` dev-dependency
- Remove accidentally committed app.log

Signed-off-by: Sebastian Barrozo <sebastian.barrozo@etendo.software>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: sebastianbarrozo <sebastian.barrozo@etendo.software>

Author: sebastianbarrozo

Cargo.lock

@@ -38,6 +38,7 @@ which = "8"
 toml = "0.8"
 
 [dev-dependencies]
+insta = "1"
 
 [profile.release]
 opt-level = 3

Cargo.toml

@@ -154,17 +154,17 @@ pub fn filter_gradle_output(output: &str) -> String {
             continue;
         }
 
-        // === * Try: block ===
+        // === * Try: block — skip all suggestion lines ===
         if trimmed == "* Try:" {
             in_try_block = true;
             continue;
         }
         if in_try_block {
-            if trimmed.starts_with("> Run with") || trimmed.starts_with("> Get more help") {
+            if trimmed.starts_with('>') || trimmed.starts_with("* ") {
                 continue;
             }
             in_try_block = false;
-            // fall through
+            // fall through — non-suggestion line ends the block
         }
 
         // === TASK LINES ===
@@ -210,9 +210,12 @@ pub fn filter_gradle_output(output: &str) -> String {
                 }
                 continue;
             }
-            if trimmed.is_empty() || trimmed.starts_with("> Task") {
+            if trimmed.starts_with("> Task")
+                || trimmed.starts_with("BUILD")
+                || trimmed.contains("tests completed")
+            {
                 in_failed_test = false;
-                // fall through
+                // fall through to process this line
             } else {
                 result.push(line.to_string());
                 continue;
@@ -263,17 +266,16 @@ pub fn filter_gradle_output(output: &str) -> String {
             continue;
         }
         if in_dep_tree {
-            // Count tree depth by pipe/space prefix
-            let depth = count_dep_depth(trimmed);
-            if depth <= dep_depth_limit {
-                // Collapse (*) duplicates
-                let clean = trimmed.replace(" (*)", "");
-                result.push(clean);
-            }
-            if trimmed.is_empty() || trimmed.starts_with("BUILD") {
+            if trimmed.starts_with("BUILD") {
                 in_dep_tree = false;
-                // fall through
+                // fall through to BUILD summary handler
             } else {
+                // Count tree depth by pipe/space prefix
+                let depth = count_dep_depth(trimmed);
+                if depth <= dep_depth_limit {
+                    let clean = trimmed.replace(" (*)", "");
+                    result.push(clean);
+                }
                 continue;
             }
         }
@@ -384,6 +386,7 @@ fn count_dep_depth(line: &str) -> usize {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use insta::assert_snapshot;
 
     fn count_tokens(text: &str) -> usize {
         text.split_whitespace().count()
@@ -841,8 +844,8 @@ BUILD SUCCESSFUL in 45s
         let output_tokens = count_tokens(&filtered);
         let savings = 100.0 - (output_tokens as f64 / input_tokens as f64 * 100.0);
         assert!(
-            savings >= 40.0,
-            "Dependency tree should have >=40% savings, got {:.1}%",
+            savings >= 60.0,
+            "Dependency tree should have >=60% savings, got {:.1}%",
             savings
         );
         // Should keep top-level deps
@@ -969,4 +972,36 @@ BUILD SUCCESSFUL in 45s
         let bin = detect_gradle_binary();
         assert_eq!(bin, "gradle");
     }
+
+    // --- Snapshot tests ---
+
+    #[test]
+    fn test_snapshot_build_success() {
+        assert_snapshot!(filter_gradle_output(BUILD_SUCCESS));
+    }
+
+    #[test]
+    fn test_snapshot_build_failed() {
+        assert_snapshot!(filter_gradle_output(BUILD_FAILED));
+    }
+
+    #[test]
+    fn test_snapshot_test_failures() {
+        assert_snapshot!(filter_gradle_output(TEST_FAILURES));
+    }
+
+    #[test]
+    fn test_snapshot_info_verbose() {
+        assert_snapshot!(filter_gradle_output(INFO_VERBOSE));
+    }
+
+    #[test]
+    fn test_snapshot_dependency_tree() {
+        assert_snapshot!(filter_gradle_output(DEPENDENCY_TREE));
+    }
+
+    #[test]
+    fn test_snapshot_etendo_smartbuild() {
+        assert_snapshot!(filter_gradle_output(ETENDO_SMARTBUILD));
+    }
 }

app.log

@@ -0,0 +1,26 @@
+---
+source: src/gradle_cmd.rs
+expression: filter_gradle_output(BUILD_FAILED)
+---
+> Task :compileTestJava FAILED
+/src/test/java/com/example/UserServiceTest.java:15: error: cannot find symbol
+    UserService service = new UserService();
+                              ^
+  symbol:   class UserService
+  location: class UserServiceTest
+/src/test/java/com/example/UserServiceTest.java:22: error: method create in class UserService cannot be applied to given types;
+    service.create(user);
+           ^
+  required: String,String
+  found: User
+1 error
+
+FAILURE: Build failed with an exception.
+
+* What went wrong:
+Execution failed for task ':compileTestJava'.
+> Compilation failed; see the compiler error output for details.
+
+
+BUILD FAILED in 5s
+3 actionable tasks: 3 executed

src/gradle_cmd.rs

@@ -0,0 +1,6 @@
+---
+source: src/gradle_cmd.rs
+expression: filter_gradle_output(BUILD_SUCCESS)
+---
+BUILD SUCCESSFUL in 2s
+7 actionable tasks: 7 up-to-date

src/snapshots/rtk__gradle_cmd__tests__snapshot_build_failed.snap

@@ -0,0 +1,18 @@
+---
+source: src/gradle_cmd.rs
+expression: filter_gradle_output(DEPENDENCY_TREE)
+---
+compileClasspath - Compile classpath for source set 'main'.
++--- org.springframework.boot:spring-boot-starter-web:3.2.0
+|    +--- org.springframework.boot:spring-boot-starter:3.2.0
+|    +--- org.springframework.boot:spring-boot-starter-json:3.2.0
+|    +--- org.springframework:spring-web:6.1.1
+|    \--- org.springframework.boot:spring-boot-starter-tomcat:3.2.0
+|         +--- jakarta.annotation:jakarta.annotation-api:2.1.1
+|         +--- org.apache.tomcat.embed:tomcat-embed-core:10.1.16
+|         \--- org.apache.tomcat.embed:tomcat-embed-websocket:10.1.16
++--- org.projectlombok:lombok:1.18.30
+\--- com.google.guava:guava:32.1.3-jre
+
+BUILD SUCCESSFUL in 1s
+1 actionable task: 1 executed

src/snapshots/rtk__gradle_cmd__tests__snapshot_build_success.snap

@@ -0,0 +1,15 @@
+---
+source: src/gradle_cmd.rs
+expression: filter_gradle_output(ETENDO_SMARTBUILD)
+---
+[ant:smartbuild] Smartbuild started
+[ant:smartbuild] Compiling module com.etendo.mymodule
+[ant:smartbuild] Generating entities for module com.etendo.mymodule
+[ant:smartbuild] Updating database for module com.etendo.mymodule
+[ant:smartbuild] Database updated successfully
+[ant:smartbuild] Deploying to tomcat
+[ant:smartbuild] Tomcat deployment complete
+[ant:smartbuild] Smartbuild completed successfully
+
+BUILD SUCCESSFUL in 45s
+12 actionable tasks: 4 executed, 8 up-to-date

src/snapshots/rtk__gradle_cmd__tests__snapshot_dependency_tree.snap

@@ -0,0 +1,6 @@
+---
+source: src/gradle_cmd.rs
+expression: filter_gradle_output(INFO_VERBOSE)
+---
+BUILD SUCCESSFUL in 1s
+7 actionable tasks: 7 up-to-date

src/snapshots/rtk__gradle_cmd__tests__snapshot_etendo_smartbuild.snap

@@ -0,0 +1,29 @@
+---
+source: src/gradle_cmd.rs
+expression: filter_gradle_output(TEST_FAILURES)
+---
+> Task :test FAILED
+
+com.example.UserServiceTest > testCreate FAILED
+    java.lang.AssertionError: expected:<200> but was:<404>
+        at org.junit.Assert.fail(Assert.java:89)
+        at org.junit.Assert.failNotEquals(Assert.java:835)
+        at org.junit.Assert.assertEquals(Assert.java:120)
+        at com.example.UserServiceTest.testCreate(UserServiceTest.java:25)
+
+com.example.OrderTest > testCancel FAILED
+    java.lang.NullPointerException
+        at com.example.OrderTest.testCancel(OrderTest.java:42)
+
+
+4 tests completed, 2 failed
+
+FAILURE: Build failed with an exception.
+
+* What went wrong:
+Execution failed for task ':test'.
+> There were failing tests. See the report at: file:///build/reports/tests/test/index.html
+
+
+BUILD FAILED in 8s
+5 actionable tasks: 1 executed, 4 up-to-date