Skip to content

Commit d3b79c3

Browse files
author
OlegDokuka
committed
fixes es6 constraints for calling constructor with new keyword
Signed-off-by: OlegDokuka <[email protected]>
1 parent 2f51d02 commit d3b79c3

3 files changed

+23
-13
lines changed

packages/rsocket-adapter-rxjs/src/Observer2BufferingSubscriberToPublisher2PrefetchingObservable.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ class Observer2BufferingSubscriberToPublisher2PrefetchingObservable<In, Out>
9292
scheduler: SchedulerLike = asyncScheduler
9393
) {
9494
super(exchangeFunction, prefetch, outputCodec, scheduler);
95-
ObserverToBufferingRSocketSubscriber.call(this, 0, undefined, inputCodec);
95+
this.init(0, undefined, inputCodec);
9696
}
9797

9898
_subscribe(s: Subscriber<Out>): TeardownLogic {

packages/rsocket-adapter-rxjs/src/ObserverToBufferingRSocketSubscriber.ts

+21-6
Original file line numberDiff line numberDiff line change
@@ -36,18 +36,33 @@ class ObserverToBufferingRSocketSubscriber<T>
3636
extends Subscription
3737
implements Observer<T>, Cancellable, Requestable, OnExtensionSubscriber
3838
{
39-
protected wip: number = 0;
39+
protected requested: number;
40+
protected subscriber: OnTerminalSubscriber &
41+
OnNextSubscriber &
42+
OnExtensionSubscriber;
43+
protected inputCodec: Codec<T>;
44+
protected wip: number;
4045
private e: Error;
4146
private done: boolean;
4247

4348
constructor(
44-
protected requested: number,
45-
protected readonly subscriber: OnTerminalSubscriber &
46-
OnNextSubscriber &
47-
OnExtensionSubscriber,
48-
protected readonly inputCodec: Codec<T>
49+
requested: number,
50+
subscriber: OnTerminalSubscriber & OnNextSubscriber & OnExtensionSubscriber,
51+
inputCodec: Codec<T>
4952
) {
5053
super();
54+
this.init(requested, subscriber, inputCodec);
55+
}
56+
57+
protected init(
58+
requested: number,
59+
subscriber: OnTerminalSubscriber & OnNextSubscriber & OnExtensionSubscriber,
60+
inputCodec: Codec<T>
61+
) {
62+
this.requested = requested;
63+
this.subscriber = subscriber;
64+
this.inputCodec = inputCodec;
65+
this.wip = 0;
5166
}
5267

5368
request(n: number) {

packages/rsocket-adapter-rxjs/src/RSocketPublisher2PrefetchingObservableToObserver2BufferingRSocketSubscriber.ts

+1-6
Original file line numberDiff line numberDiff line change
@@ -74,12 +74,7 @@ class RSocketPublisher2PrefetchingObservableToObserver2BufferingRSocketSubscribe
7474
scheduler: SchedulerLike = asyncScheduler
7575
) {
7676
super(() => subscriber, prefetch, outputCodec, scheduler);
77-
ObserverToBufferingRSocketSubscriber.call(
78-
this,
79-
requested,
80-
subscriber,
81-
inputCodec
82-
);
77+
this.init(requested, subscriber, inputCodec);
8378
}
8479

8580
protected _subscribe(observer: Subscriber<any>): TeardownLogic {

0 commit comments

Comments
 (0)