Skip to content

Commit 2bc33d9

Browse files
committed
chore: remove TODO comments
Signed-off-by: Kevin Viglucci <[email protected]>
1 parent 4444c17 commit 2bc33d9

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

packages/rsocket-adapter-async/src/lib/requesters/requestResponse.ts

-2
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ export default function requestResponse<TData, RData>(
2525
return new Promise((resolve, reject) => {
2626
rsocket.requestResponse(payload, {
2727
onNext(payload: Payload): void {
28-
// TODO: is there data loss by only resolving with `payload.data`?
29-
// should metadata be included in the resolved value?
3028
resolve(outputCodec.decode(payload.data));
3129
},
3230
onComplete(): void {

packages/rsocket-adapter-async/src/lib/requesters/requestStream.ts

-2
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ export default function requestStream<TData, RData>(
2121
) {
2222
const exchangeFunction = (subscriber, initialRequestN) => {
2323
const payload = {
24-
// TODO: should inputCodec be responsible for handling empty data?
25-
// TODO: Buffer needs to be injectable to support browsers
2624
data: data ? inputCodec.encode(data) : Buffer.allocUnsafe(0),
2725
metadata: encodeCompositeMetadata(metadata),
2826
};

0 commit comments

Comments
 (0)