-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is the current status of this work? #5
Comments
Hi, I am afraid that the status is "possibly a good start, but this needs attention, more tests for design (how practical or helpful is this), more documentations and examples, and more automated tests". I only got time very recently to fix it to pass current tests, with the aim of having a release on Pypi by the end of the year. I am happy to welcome additional participants, including opinionated participation. The Answers to the numbered points: 1/ 2/ 3/ |
The renaming of the package from PROs:
CONs:
|
Nice! I doubt there are many links to the old name (and GitHub redirects anyway for a good time). I'll follow up about the other items when I get a chance! |
If there is a redirect this is a no-brainer. Renamed to |
Release 0.0.1 is now on Pypi: https://pypi.org/project/rpy2-r6/ |
Hi again @lgautier !
I wanted to connect and finally close the loop on all of this work. We are still using my original wrappers internally (the basis of R6a), which largely continue to work well, but I'd like to port our code over to upstream wrappers where possible to reduce the maintenance burden internally (and to help yourself and others to have a robust set of wrapper that they can use also).
I played with the existing code here and found lots of rough edges in your port of my original contribution (R6a), and even more rough edges in the experimental class generation code (R6b). I'm more than happy to work with you to get a robust implementation working, and then prove that it works by porting our fairly complex use-cases onto this upstream code; assuming you remain interested.
What follows are some general thoughts about the direction in which we might move to finish this body of work.
I think I generally like the class generation procedure over wrapping just the current state of R6 instances/classes in the R interpreter; though in practice this basically only provides some extra metadata (since the R interpreter state/class MRO/etc is the only one that matters). Since the R state is what matters here, I wonder if the implementation of R6b can't be simplified to be a little more like R6a. I'm happy to come up with an example implementation to demonstrate this if you are interested. Once we find something we are happy with I think we can just provide a single implementation. I won't be offended if R6a disappears.
Minor point: perhaps we can name the Python module
rpy2_r6
rather than using capitals?How should the collaboration work here? Would it make sense, after I have a rough draft of (1) above, to schedule some live conversation time to homogenise more quickly? Are there any other considerations I'm missing?
Thanks again for your openness to contributions!
The text was updated successfully, but these errors were encountered: