Skip to content

Commit e914e3d

Browse files
jonathanmccannbrianchandotcom
authored andcommitted
LPS-107922 Use 'distinct' to avoid retrieving thousands of duplicate articles
1 parent fdb1281 commit e914e3d

File tree

1 file changed

+4
-4
lines changed
  • modules/apps/knowledge-base/knowledge-base-service/src/main/java/com/liferay/knowledge/base/internal/upgrade/v2_0_2

1 file changed

+4
-4
lines changed

modules/apps/knowledge-base/knowledge-base-service/src/main/java/com/liferay/knowledge/base/internal/upgrade/v2_0_2/UpgradeKBArticle.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,8 @@ private boolean _renameConflictingKBArticleFriendlyURLs()
116116

117117
return _renameConflictingFriendlyURL(
118118
StringBundler.concat(
119-
"select kbArticle2.kbArticleId, kbArticle2.urlTitle from ",
120-
"KBArticle kbArticle1 inner join KBArticle kbArticle2 on ",
119+
"select distinct kbArticle2.kbArticleId, kbArticle2.urlTitle ",
120+
"from KBArticle kbArticle1 inner join KBArticle kbArticle2 on ",
121121
"kbArticle1.groupId = kbArticle2.groupId and ",
122122
"kbArticle1.kbFolderId = kbArticle2.kbFolderId and ",
123123
"kbArticle1.urlTitle = kbArticle2.urlTitle where ",
@@ -130,8 +130,8 @@ private boolean _renameConflictingKBFolderFriendlyURLs()
130130

131131
return _renameConflictingFriendlyURL(
132132
StringBundler.concat(
133-
"select kbArticle2.kbFolderId, kbArticle2.urlTitle from ",
134-
"KBFolder kbArticle1 inner join KBFolder kbArticle2 on ",
133+
"select distinct kbArticle2.kbFolderId, kbArticle2.urlTitle ",
134+
"from KBFolder kbArticle1 inner join KBFolder kbArticle2 on ",
135135
"kbArticle1.groupId = kbArticle2.groupId and ",
136136
"kbArticle1.parentKBFolderId = kbArticle2.parentKBFolderId ",
137137
"and kbArticle1.urlTitle = kbArticle2.urlTitle where ",

0 commit comments

Comments
 (0)