From 8863dbaa03f1b8a9ac3f537c59220fc4ea329bd2 Mon Sep 17 00:00:00 2001 From: mini-1235 Date: Sun, 9 Nov 2025 10:48:19 +0000 Subject: [PATCH 1/2] Remove unnecessary subscription in test Signed-off-by: mini-1235 --- test/test_subscriber.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/test_subscriber.cpp b/test/test_subscriber.cpp index 3b38ac2..6f3b887 100644 --- a/test/test_subscriber.cpp +++ b/test/test_subscriber.cpp @@ -281,8 +281,6 @@ TEST(Subscriber, multipleCallbacksSomeFilterSomeDirect) rclcpp::QoS(rclcpp::QoSInitialization::from_rmw(rmw_qos_profile_default)); message_filters::Subscriber sub(node, "test_topic", default_qos); sub.registerCallback(&NonConstHelper::cb, &h); - auto sub2 = node->create_subscription( - "test_topic", 10, std::bind(&NonConstHelper::cb, &h2, std::placeholders::_1)); auto pub = node->create_publisher("test_topic", 10); auto msg = std::make_unique(); From 29e12becdfc8b9ed4bc7cd6d997325caa301ddc1 Mon Sep 17 00:00:00 2001 From: mini-1235 Date: Sun, 9 Nov 2025 11:50:57 +0000 Subject: [PATCH 2/2] Update tests Signed-off-by: mini-1235 --- test/test_subscriber.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/test_subscriber.cpp b/test/test_subscriber.cpp index 6f3b887..436a11d 100644 --- a/test/test_subscriber.cpp +++ b/test/test_subscriber.cpp @@ -276,11 +276,13 @@ TEST(Subscriber, multipleCallbacksSomeFilterSomeDirect) auto node = std::make_shared("test_node"); rclcpp::executors::SingleThreadedExecutor executor; executor.add_node(node); - NonConstHelper h, h2; + ConstHelper h, h2; rclcpp::QoS default_qos = rclcpp::QoS(rclcpp::QoSInitialization::from_rmw(rmw_qos_profile_default)); message_filters::Subscriber sub(node, "test_topic", default_qos); - sub.registerCallback(&NonConstHelper::cb, &h); + sub.registerCallback(&ConstHelper::cb, &h); + auto sub2 = node->create_subscription( + "test_topic", 10, std::bind(&ConstHelper::cb, &h2, std::placeholders::_1)); auto pub = node->create_publisher("test_topic", 10); auto msg = std::make_unique();