Add magnetic_field_sensor semantic component #2627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
LukasMacha97,
bmagyar,
erickisos,
fmauch,
mamueluth,
mhubii and
saikishor
saikishor
reviewed
Oct 7, 2025
controller_interface/include/semantic_components/magnetic_field_sensor.hpp
Outdated
Show resolved
Hide resolved
controller_interface/include/semantic_components/magnetic_field_sensor.hpp
Outdated
Show resolved
Hide resolved
saikishor
reviewed
Oct 8, 2025
controller_interface/include/semantic_components/magnetic_field_sensor.hpp
Outdated
Show resolved
Hide resolved
christophfroehlich
requested changes
Oct 8, 2025
christophfroehlich
requested changes
Oct 8, 2025
|
Thanks for the reviews! Everything is fixed except the release notes. I will fix them once #2646 is merged, to avoid merge conflicts. |
christophfroehlich
approved these changes
Oct 9, 2025
|
Don't know how I made so many mistakes in this PR. 🤦♂ |
saikishor
approved these changes
Oct 9, 2025
christophfroehlich
merged commit df846fe
into
ros-controls:master
13 of 17 checks passed
|
@christophfroehlich @saikishor, is a backport to Jazzy possible? |
christophfroehlich
added
backport-jazzy
mergify bot
pushed a commit
that referenced
this pull request
Oct 12, 2025
(cherry picked from commit df846fe)
mergify bot
pushed a commit
that referenced
this pull request
Oct 12, 2025
(cherry picked from commit df846fe)
saikishor
pushed a commit
that referenced
this pull request
Oct 12, 2025
(cherry picked from commit df846fe) Co-authored-by: Aarav Gupta <[email protected]>
christophfroehlich
pushed a commit
that referenced
this pull request
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new semantic component for magnetometers/
magnetic_field_sensors.I plan to add support for magnetometers to the imu_broadcaster (this will come with a
has_magnetometerparameter), as many IMUs have built-in magnetometers.Alongside this, I also plan on adding support for filtering to the broadcaster through the filters present in imu_tools.
Please review this PR and tell me if you are okay with the above.